Merge bileto:drop-obsolete-series into bileto:master

Proposed by Steve Langasek
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: e549646bd9be50ae012272948436b5c70cf7768b
Merged at revision: e549646bd9be50ae012272948436b5c70cf7768b
Proposed branch: bileto:drop-obsolete-series
Merge into: bileto:master
Diff against target: 47 lines (+2/-9)
2 files modified
bileto/v2.py (+1/-7)
tests/test_v2.py (+1/-2)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+357863@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is good, but needs some additional changes. Right now the tests are failing as there are places where SERIES is still referenced.

But I'll fix that.

review: Needs Fixing
Revision history for this message
Łukasz Zemczak (sil2100) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bileto/v2.py b/bileto/v2.py
2index b6a3c3c..a6cc3e7 100644
3--- a/bileto/v2.py
4+++ b/bileto/v2.py
5@@ -34,12 +34,6 @@ FAILURES = ('can\'t', 'caught', 'error', 'exception',
6 EXPAND = {'search'}
7 CONTRACT = EXPAND | {'comments', 'merge_proposals'}
8 SLASH = '/'
9-SERIES = [
10- 'zesty-overlay, xenial-overlay',
11- 'zesty, xenial-overlay',
12- 'zesty, yakkety',
13- 'zesty, yakkety, xenial',
14-]
15
16
17 def assert_json():
18@@ -195,7 +189,7 @@ def v2_metadata_get():
19 lander_signoff=signoff,
20 qa_signoff=['Ready'] + signoff,
21 distribution=['ubuntu'],
22- series=SERIES + series,
23+ series=series,
24 dest=['', '{}/ubuntu/stable-phone-overlay'.format(team)],
25 status=(
26 'New',
27diff --git a/tests/test_v2.py b/tests/test_v2.py
28index 412c844..0a56d44 100644
29--- a/tests/test_v2.py
30+++ b/tests/test_v2.py
31@@ -12,7 +12,6 @@ from mock import patch
32
33 from bileto.models import Ticket, Comment
34 from bileto.app import db
35-from bileto.v2 import SERIES
36
37 from tests.tests import BiletoTestCase
38
39@@ -631,7 +630,7 @@ class V2TestCase(BiletoTestCase):
40 distribution=['ubuntu'],
41 lander_signoff=['', 'Approved', 'Failed'],
42 qa_signoff=['Ready', '', 'Approved', 'Failed'],
43- series=SERIES + ['alpha', 'beta'],
44+ series=['alpha', 'beta'],
45 status=['New', 'Landed', 'Abandoned']),
46 ppa_team='team-not-set',
47 devel='alpha',

Subscribers

People subscribed via source and target branches

to all changes: