Bileto

Merge bileto:no-new-tabs into bileto:master

  1. Git
  2. lp:bileto
  3. no-new-tabs
  4. Merge into master
Proposed by Steve Langasek
Status: Needs review
Proposed branch: bileto:no-new-tabs
Merge into: bileto:master
Diff against target: 14 lines (+2/-2)
1 file modified
bileto/static/app.html (+2/-2)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Pending
Review via email: mp+322557@code.launchpad.net
To post a comment you must log in.

Unmerged commits

5bf9e5a... by Steve Langasek

Don't open a new tab for abandon and finalize on every ticket.

This leaves extra unnecessary tabs around to be closed. If navigating back
to the main page from these action screens is problematic, we should fix
that instead, or else support these actions inline in the ticket screen.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bileto/static/app.html b/bileto/static/app.html
2index 324103d..47635d4 100644
3--- a/bileto/static/app.html
4+++ b/bileto/static/app.html
5@@ -231,8 +231,8 @@
6 <a href="/log/{{ticket.id}}/revert" target="_blank">Revert</a>
7 <a href="/log/{{ticket.id}}/snap" target="_blank" ng-if="ticket.snaps">Snap</a>
8 <a href="/log/{{ticket.id}}/publish" target="_blank" ng-if="ticket.ppa">Publish</a>
9-<a href="/log/{{ticket.id}}/finalize" target="_blank">Finalize</a>
10-<a href="/log/{{ticket.id}}/abandon" target="_blank">Abandon</a>
11+<a href="/log/{{ticket.id}}/finalize">Finalize</a>
12+<a href="/log/{{ticket.id}}/abandon">Abandon</a>
13 </div>
14 </div>
15

Subscribers

People subscribed via source and target branches

to all changes: