Merge lp:~bilalakhtar/update-manager/unity-crash-fix into lp:update-manager

Proposed by Bilal Akhtar on 2011-05-16
Status: Rejected
Rejected by: Michael Terry on 2011-06-01
Proposed branch: lp:~bilalakhtar/update-manager/unity-crash-fix
Merge into: lp:update-manager
Diff against target: 12 lines (+1/-1)
1 file modified
UpdateManager/UnitySupport.py (+1/-1)
To merge this branch: bzr merge lp:~bilalakhtar/update-manager/unity-crash-fix
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team 2011-05-16 Pending
Review via email: mp+61066@code.launchpad.net

Description of the change

Fix the crash in Unity by using the ENABLED property instead of VISIBLE. We may revert this later when bug #759174 is fixed in Unity.

To post a comment you must log in.
Bilal Akhtar (bilalakhtar) wrote :

I guess this would need more discussion before implementation.

I've filed merge request https://code.launchpad.net/~bilalakhtar/unity/fix-unity-crash-on-hidden-quicklistitem/+merge/61067 which fixes the Unity crash on setting VISIBLE to false.

Now we have 2 choices:

1) Go with the current arrangement, since that Unity branch should land in very soon.

2) Use the ENABLED property to disable/enable the Install All Updates button, even when the Unity bug gets fixed.

Its an ergonomic difference. Michael?

Michael Terry (mterry) wrote :

I'm not the Michael you meant, but I'm just going to go ahead and say we can drop this. The Unity bug got fixed in oneiric. Let's just stay the status quo. mvo can whack me if I'm wrong.

Unmerged revisions

2109. By Bilal Akhtar on 2011-05-16

Use MENUITEM_PROP_ENABLED until Unity is fixed to support the Visible property

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/UnitySupport.py'
2--- UpdateManager/UnitySupport.py 2011-05-02 16:19:57 +0000
3+++ UpdateManager/UnitySupport.py 2011-05-16 05:23:23 +0000
4@@ -74,7 +74,7 @@
5 self._unity.set_property("urgent", False)
6
7 def set_install_menuitem_visible(self, visible):
8- self.install_dbusmenuitem.property_set_bool(Dbusmenu.MENUITEM_PROP_VISIBLE, visible)
9+ self.install_dbusmenuitem.property_set_bool(Dbusmenu.MENUITEM_PROP_ENABLED, visible)
10
11
12 # check what to export to the clients

Subscribers

People subscribed via source and target branches

to status/vote changes: