Code review comment for lp:~bilalakhtar/unity/unhide-launcher-sc-fix-1002440

Revision history for this message
Tim Penhey (thumper) wrote :

Would it not make sense to have an early return?

It seems that you are going to create a new launcher icon even if you are not going to show the launcher.
Is this what you expect?

Also,
  (!path.empty() && !path.compare("software-center-agent"))
is not very readable... how about
  (path == "software-centre=agent")

review: Needs Fixing

« Back to merge proposal