lp:~bilalakhtar/unity/fix-740867

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:unity

Didier Roche-Tolomelli: Disapprove on 2011-03-23

Diff: 60 lines (+26/-0)

2 files modified

src/BamfLauncherIcon.cpp (+25/-0)
src/BamfLauncherIcon.h (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #709707: Middle click on application icon should open a new window	Medium	Fix Released
Bug #740867: Right-click launcher menu should have 'Open a new window' option	Undecided	Opinion

Link a bug report

Related blueprints

1001. By Bilal Akhtar on 2011-03-23

Add 'Open a new window' item to quicklist of BamfLauncherIcon

1000. By Neil J. Patel on 2011-03-23

MUHAHAHHA

999. By Didier Roche-Tolomelli on 2011-03-23

enable removing symlink (LP: #740779)

998. By Jason Smith on 2011-03-22

ensure we dont allow dragging of windows that shouldn't be dragged

997. By Jason Smith on 2011-03-22

fix startup initialization

996. By Didier Roche-Tolomelli on 2011-03-22

unitymtgrabhandles to require imgpng

995. By Mirco Müller on 2011-03-22

modified:
  src/SimpleLauncherIcon.cpp
  src/SimpleLauncherIcon.h

Patch from Marco Biscaro to reload icons in launcher upon
icon-theme-change. Fixes LP: #605475. Thanks a lot for the fix, Marco!

994. By Gord Allott on 2011-03-22

Enables subpixel support in unity places and pushes the font up by one point - should help with lp:727799

993. By Mirco Müller on 2011-03-22

modified:
  src/Launcher.cpp
  src/Launcher.h
  src/PlacesTile.cpp
  src/PlacesTile.h
  src/QuicklistMenuItem.cpp
  src/QuicklistMenuItem.h
  src/QuicklistMenuItemCheckmark.cpp
  src/QuicklistMenuItemLabel.cpp
  src/QuicklistMenuItemRadio.cpp
  src/QuicklistView.cpp
  src/Tooltip.cpp

Merged unity.remove-redundant-cairo-code to trunk after review and
approval from Gordon. This does clean up the cairo rendering-code
quite a bit, which deletes lots of duplicated code and makes the
remaining code less error-prone. It uses the API for drawing
pixel-grid aligned rounded rectangles and blurring cairo image-surfaces,
which were recently added to nux. Quicklists, Tooltips, Dash,
Place-Tiles all still render correctly.

992. By Didier Roche-Tolomelli on 2011-03-22

Merge Dylan's work after resolving a merge confict! Thanks a lot/

This branch changes the mechanics for the top panel acting as a titlebar.
Previously, the top panel could be dragged in order to unmaximize (and move) a
maximized window, but only if that window was in focus. This opened up some
issues, which are covered in bug #716177.

With this branch, Unity's PanelMenuView maintains a list of maximized windows.
(Note: When I say “maximized window,” I really mean “a window that Unity has
started decorating instead of the window decorator.” Right now, that is limited
to maximized windows).

When the user clicks the top panel, that click affects the front-most of the
PanelMenuView's maximized windows. Previously, OnMaximizedGrab would only affect
the active window if it was maximized.
I also added some code to Activate the front-most maximized window, bringing it
into focus when the top panel is clicked.

There is some intricacy involving multiple viewports and desktops, where the top
panel should never act as a titlebar for a window that is not visible (be it
behind another maximized window or on a different viewport). I believe I have
covered the appropriate cases in WindowManager::IsWindowOnCurrentDesktop and
WindowManager::IsWindowObscured.

Fix:

Bug #716177: The Unity Panel's window controls and window dragging features
should work for the uppermost maximized window regardless of current window in
focus
Bug #723882: When a maximized window has window on top of it in 'restored state'
(not maximised) , it is not possible to un-maximized the window by dragging the
title bar downwards
Bug #736580: Possible race condition in PanelMenuView::OnWindowMaximized and
OnWindowRestored