Merge lp:~bilalakhtar/unity-lens-applications/fix-750262 into lp:unity-lens-applications

[Bilal Akhtar]

This branch fixes bug #750262 .

[Mikkel Kamstrup Erlandsen (kamstrup)]

There's something about this implementation I don't like too much. Right now you extract the package name and pass it to software-center. This only works by chance.

The "correct" way would be to pass the full "apt:package_name" string to AppInfo.launch_default_for_uri() because the apt: scheme is already registered with GNOME as you can verify by running "gnome-open apt:xterm" in a terminal.

review: Needs Fixing

[Mikkel Kamstrup Erlandsen (kamstrup)]

(and note - the reason why the unity-install:// scheme doesn't work "by chance" in general is because we extract all the metadata directly from software-center's own index when constructing the URL)

[lp:~bilalakhtar/unity-lens-applications/fix-750262]

202. By Bilal Akhtar on 2011-04-06

Make sure apturl runs in the case of an apt: url, and not software-center

[Mikkel Kamstrup Erlandsen (kamstrup)]

Awesome Bilal! I saw your ping on IRC yesterday just when my laptop's battery died. I still think that AppInfo.launch_default_for_uri() is the right choice. The apt:foo thing is mainly for power users and I am not convinced they appreciate a full S-C launched.

And using the GNOME URI handling we give the platform team the option to install the software-center as apt: URI handler if they see that as better. Which hardcoding S-C doesn't make room for.

Your patch will be included in todays tarball.

review: Approve

=== modified file 'src/daemon.vala'
--- src/daemon.vala	2011-03-31 10:48:54 +0000
+++ src/daemon.vala	2011-04-06 15:06:36 +0000
@@ -763,11 +763,20 @@
         {
           string orig;
           orig = uri.offset (15);
-          exec_or_dir = Utils.subst_tilde (orig);
-          args = exec_or_dir.split (" ", 0);
-          for (int i = 0; i < args.length; i++)
-            args[i] = Utils.subst_tilde (args[i]);
-
+          if (orig.has_prefix ("apt:")) {
+            try {
+              AppInfo.launch_default_for_uri (orig, null);
+            } catch (GLib.Error error) {
+              warning ("failed to install package %s", orig.offset(4));
+              return ActivationStatus.NOT_ACTIVATED;
+            }
+            return ActivationStatus.ACTIVATED_HIDE_DASH;
+          } else {
+            exec_or_dir = Utils.subst_tilde (orig);
+            args = exec_or_dir.split (" ", 0);
+            for (int i = 0; i < args.length; i++)
+              args[i] = Utils.subst_tilde (args[i]);
+          }
           this.runner.add_history (orig);
         }
       else