Merge lp:~bilalakhtar/ubuntu/maverick/rhythmbox/fix-620326 into lp:ubuntu/maverick/rhythmbox

Proposed by Bilal Akhtar
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~bilalakhtar/ubuntu/maverick/rhythmbox/fix-620326
Merge into: lp:ubuntu/maverick/rhythmbox
Diff against target: 93 lines (+22/-19)
2 files modified
debian/changelog (+7/-0)
debian/patches/07_pause_button.patch (+15/-19)
To merge this branch: bzr merge lp:~bilalakhtar/ubuntu/maverick/rhythmbox/fix-620326
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Ubuntu Sponsors Pending
Review via email: mp+33096@code.launchpad.net

Description of the change

This branch fixes bug #620326 .

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-08-13 15:07:18 +0000
3+++ debian/changelog 2010-08-19 11:31:41 +0000
4@@ -1,3 +1,10 @@
5+rhythmbox (0.13.0git20100715-0ubuntu9) maverick; urgency=low
6+
7+ * debian/patches/07_pause_button.patch:
8+ - Remove label from Play/Pause button. (LP: #620326)
9+
10+ -- Bilal Akhtar <bilalakhtar@ubuntu.com> Thu, 19 Aug 2010 14:19:55 +0300
11+
12 rhythmbox (0.13.0git20100715-0ubuntu8) maverick; urgency=low
13
14 * debian/control.in:
15
16=== modified file 'debian/patches/07_pause_button.patch'
17--- debian/patches/07_pause_button.patch 2010-08-16 18:02:29 +0000
18+++ debian/patches/07_pause_button.patch 2010-08-19 11:31:41 +0000
19@@ -5,11 +5,9 @@
20 Author: Bilal Akhtar <bilalakhtar@ubuntu.com>
21 Bug-Ubuntu: https://bugs.edge.launchpad.net/hundredpapercuts/+bug/71228
22 Forwarded: https://bugzilla.gnome.org/show_bug.cgi?id=326066
23-diff --git a/shell/rb-shell-player.c b/shell/rb-shell-player.c
24-index 4570d14..be4a03f 100644
25 --- a/shell/rb-shell-player.c
26 +++ b/shell/rb-shell-player.c
27-@@ -305,6 +305,9 @@ enum
28+@@ -305,6 +305,9 @@
29
30 static GtkActionEntry rb_shell_player_actions [] =
31 {
32@@ -19,7 +17,7 @@
33 { "ControlPrevious", GTK_STOCK_MEDIA_PREVIOUS, N_("Pre_vious"), "<alt>Left",
34 N_("Start playing the previous song"),
35 G_CALLBACK (rb_shell_player_cmd_previous) },
36-@@ -322,9 +325,6 @@ static guint rb_shell_player_n_actions = G_N_ELEMENTS (rb_shell_player_actions);
37+@@ -322,9 +325,6 @@
38
39 static GtkToggleActionEntry rb_shell_player_toggle_entries [] =
40 {
41@@ -29,7 +27,17 @@
42 { "ControlShuffle", GNOME_MEDIA_SHUFFLE, N_("Sh_uffle"), "<control>U",
43 N_("Play songs in a random order"),
44 G_CALLBACK (rb_shell_player_shuffle_changed_cb) },
45-@@ -3745,7 +3745,6 @@ _idle_unblock_signal_cb (gpointer data)
46+@@ -688,9 +688,6 @@
47+ rb_shell_player_n_toggle_entries,
48+ player);
49+
50+- action = gtk_action_group_get_action (player->priv->actiongroup,
51+- "ControlPlay");
52+- g_object_set (action, "is-important", TRUE, NULL);
53+
54+ player->priv->syncing_state = TRUE;
55+ rb_shell_player_set_playing_source (player, NULL);
56+@@ -3745,7 +3742,6 @@
57
58 /* sync the active state of the action again */
59 g_object_get (player, "playing", &playing, NULL);
60@@ -37,7 +45,7 @@
61
62 g_signal_handlers_unblock_by_func (action, rb_shell_player_cmd_play, player);
63
64-@@ -3768,11 +3767,17 @@ rb_shell_player_playing_changed_cb (RBShellPlayer *player,
65+@@ -3768,11 +3764,17 @@
66 if (playing) {
67 if (rb_source_can_pause (player->priv->source)) {
68 tooltip = g_strdup (_("Pause playback"));
69@@ -55,7 +63,7 @@
70 }
71 g_object_set (action, "tooltip", tooltip, NULL);
72 g_free (tooltip);
73-@@ -3784,7 +3789,6 @@ rb_shell_player_playing_changed_cb (RBShellPlayer *player,
74+@@ -3784,7 +3786,6 @@
75 if (player->priv->unblock_play_id == 0) {
76 g_signal_handlers_block_by_func (action, rb_shell_player_cmd_play, player);
77 }
78@@ -63,15 +71,3 @@
79
80 if (player->priv->unblock_play_id == 0) {
81 player->priv->unblock_play_id = g_idle_add (_idle_unblock_signal_cb, player);
82---- a/shell/rb-shell.c
83-+++ b/shell/rb-shell.c
84-@@ -1478,6 +1478,9 @@
85- toolbar = gtk_ui_manager_get_widget (shell->priv->ui_manager, "/ToolBar");
86- gtk_box_pack_start (GTK_BOX (hbox), toolbar, TRUE, TRUE, 0);
87-
88-+ GtkWidget* playbutton = gtk_ui_manager_get_widget (shell->priv->ui_manager, "/ToolBar/Play");
89-+ gtk_widget_set_size_request(GTK_WIDGET(playbutton), 80, -1);
90-+
91- shell->priv->volume_button = gtk_volume_button_new ();
92- g_signal_connect (shell->priv->volume_button, "value-changed",
93- G_CALLBACK (rb_shell_volume_widget_changed_cb),

Subscribers

People subscribed via source and target branches

to all changes: