Merge lp:~bilalakhtar/ubiquity/fix-492825-2 into lp:ubiquity

Proposed by Bilal Akhtar on 2010-08-02
Status: Merged
Merged at revision: 4144
Proposed branch: lp:~bilalakhtar/ubiquity/fix-492825-2
Merge into: lp:ubiquity
Diff against target: 35 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/ubiquity.templates (+1/-1)
To merge this branch: bzr merge lp:~bilalakhtar/ubiquity/fix-492825-2
Reviewer Review Type Date Requested Status
Colin Watson 2010-08-02 Approve on 2010-08-02
Review via email: mp+31526@code.launchpad.net

Description of the change

This branch fixes bug #492825 .

To post a comment you must log in.
Colin Watson (cjwatson) wrote :

Is this really the best way? What if the translation of "Install"
begins with a letter already used as the accelerator key for the
translation of "Back" or "Forward"? I would have thought that the
correct fix was to change the string to "_Install", and permit
translators to select an appropriate accelerator key; that's how
translations for "Back" and "Forward" are handled.

gui/gtk/ubiquity.ui sets the use_underline property to True for the next
widget, so the set_use_underline call is unnecessary.

Bilal Akhtar (bilalakhtar) wrote :

Colin,
Even I thought of that. But, then we would need to re-generate translation templates. What do you think?

Colin Watson (cjwatson) wrote :

We aren't in a translation freeze right now and shouldn't shy away from
regenerating translation templates when it's the right thing to do.

4145. By Bilal Akhtar on 2010-08-02

Modified stuff a bit, thanks Colin

Bilal Akhtar (bilalakhtar) wrote :

Colin,
please see now.

Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-07-30 20:50:29 +0000
3+++ debian/changelog 2010-08-02 13:27:45 +0000
4@@ -1,5 +1,6 @@
5 ubiquity (2.3.4) UNRELEASED; urgency=low
6
7+ [ Mario Limonciello ]
8 * Also set the custom title when translating widgets.
9 * If there is at least one framebuffer device, fallback to fbdev rather
10 than vesa for bulletproof X.
11@@ -9,6 +10,11 @@
12 primarily intended for systems where the installation kernel has known
13 graphics problems, but you are solving them in a post installation step.
14
15+ [ Bilal Akhtar ]
16+ * debian/ubiquity.templates:
17+ - Add an underline symbol before the label of the install button
18+ to make it accessible with the Alt key. (LP: #492825)
19+
20 -- Mario Limonciello <Mario_Limonciello@Dell.com> Thu, 29 Jul 2010 00:05:19 -0500
21
22 ubiquity (2.3.3) maverick; urgency=low
23
24=== modified file 'debian/ubiquity.templates'
25--- debian/ubiquity.templates 2010-07-30 20:50:29 +0000
26+++ debian/ubiquity.templates 2010-08-02 13:27:45 +0000
27@@ -343,7 +343,7 @@
28 Type: text
29 # This is used as a button label, and should be translated as an action.
30 # Omit the [ ... ] from the translation.
31-_Description: Install[ action ]
32+_Description: _Install[ action ]
33
34 Template: ubiquity/text/step_label
35 Type: text

Subscribers

People subscribed via source and target branches

to status/vote changes: