Merge lp:~bilalakhtar/gnome-media-player/bugfix into lp:gnome-media-player/0.1

Proposed by Bilal Akhtar
Status: Merged
Merged at revision: not available
Proposed branch: lp:~bilalakhtar/gnome-media-player/bugfix
Merge into: lp:gnome-media-player/0.1
Diff against target: 38 lines (+4/-2)
3 files modified
Makefile.am (+2/-0)
Makefile.in (+1/-1)
src/main_window.cc (+1/-1)
To merge this branch: bzr merge lp:~bilalakhtar/gnome-media-player/bugfix
Reviewer Review Type Date Requested Status
Michael Lamothe (community) final Approve
Review via email: mp+19693@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Also, I have fixed a bug in the makefile. The bug was that if one types "make dist" then an error would come because the package wasn't properly declared. The bug has been fixed in this branch

Revision history for this message
Michael Lamothe (lamothe-deactivatedaccount-deactivatedaccount) wrote :

Looks good to me. Thanks for the fix.

review: Approve (final)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile.am'
2--- Makefile.am 2010-01-30 14:32:43 +0000
3+++ Makefile.am 2010-02-19 10:40:32 +0000
4@@ -3,6 +3,8 @@
5
6 SUBDIRS = src po
7
8+PACKAGE = gnome-media-player
9+
10 desktopdir = $(datadir)/applications
11 desktop_in_files = gnome-media-player.desktop.in
12 desktop_DATA = $(desktop_in_files:.desktop.in=.desktop)
13
14=== modified file 'Makefile.in'
15--- Makefile.in 2010-01-30 14:32:43 +0000
16+++ Makefile.in 2010-02-19 10:40:32 +0000
17@@ -196,7 +196,7 @@
18 OBJEXT = @OBJEXT@
19 OTOOL = @OTOOL@
20 OTOOL64 = @OTOOL64@
21-PACKAGE = @PACKAGE@
22+PACKAGE = gnome-media-player
23 PACKAGE_BUGREPORT = @PACKAGE_BUGREPORT@
24 PACKAGE_NAME = @PACKAGE_NAME@
25 PACKAGE_STRING = @PACKAGE_STRING@
26
27=== modified file 'src/main_window.cc'
28--- src/main_window.cc 2010-02-16 20:09:50 +0000
29+++ src/main_window.cc 2010-02-19 10:40:32 +0000
30@@ -324,7 +324,7 @@
31 list_store->clear();
32 add_to_playlist(filename);
33 g_free (filename);
34-
35+image_play->set(Gtk::Stock::MEDIA_PAUSE, Gtk::ICON_SIZE_MENU);
36 action_play->activate();
37 }
38 gtk_widget_destroy (dialog);

Subscribers

People subscribed via source and target branches

to all changes: