Code review comment for lp:~bigkevmcd/landscape-client/bootstrap-with-userdata-ca

Revision history for this message
Sidnei da Silva (sidnei) wrote :

[1] PEP8 still there:

landscape/configuration.py:515:5: E301 expected 1 blank line, found 2
landscape/tests/test_configuration.py:1492:1: E302 expected 2 blank lines, found 3
landscape/tests/test_configuration.py:1522:9: E301 expected 1 blank line, found 2
landscape/tests/test_configuration.py:1573:9: E301 expected 1 blank line, found 2

[2] The lines following the change from assertEquals to assertEqual are now wrongly indented (there's one space too much).

review: Approve

« Back to merge proposal