Juju Charms Collection
apache-hadoop-compute-slave package

Code review comment for lp:~bigdata-dev/charms/trusty/apache-hadoop-compute-slave/status

  1. Trusty Tahr (14.04)
  2. status
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

> Looks really good Cory! I deployed to AWS and all the status changes looked
> legit (i like the inclusion of '/etc/hosts registration' in addition to the
> normal boring enhanced status).

What /etc/hosts registration are you referring to?

> I have a beef, though. This feels heavy:
>
> + archives = glob('resources/*')
> + subprocess.check_call(['pip', 'install'] + archives)
>
> What if we want to shove things in ./resources that aren't pip'able? We can
> either cross that bridge when we get to it, or shove pip stuffs in
> ./resources/pip. Thoughts?

Yeah. Honestly, I just got tired of adding things there that I had missed. Could do a python subdirectory, though.

« Back to merge proposal