Merge lp:~bigdata-dev/charms/trusty/apache-hadoop-client/trunk into lp:charms/trusty/apache-hadoop-client

Proposed by Cory Johns
Status: Merged
Merged at revision: 102
Proposed branch: lp:~bigdata-dev/charms/trusty/apache-hadoop-client/trunk
Merge into: lp:charms/trusty/apache-hadoop-client
Diff against target: 103 lines (+4/-43)
4 files modified
README.md (+1/-1)
tests/00-setup (+0/-8)
tests/01-basic-deployment.py (+0/-34)
tests/tests.yaml (+3/-0)
To merge this branch: bzr merge lp:~bigdata-dev/charms/trusty/apache-hadoop-client/trunk
Reviewer Review Type Date Requested Status
Kevin W Monroe Approve
Review via email: mp+273434@code.launchpad.net

Description of the change

Remove trivial test in favor of bundle tests.

To post a comment you must log in.
102. By Cory Johns

Re-added trivial test

103. By Cory Johns

Update mailing list

Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

LGTM, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README.md'
2--- README.md 2015-08-24 23:19:00 +0000
3+++ README.md 2015-10-06 18:07:13 +0000
4@@ -25,7 +25,7 @@
5
6 ## Contact Information
7
8-- <bigdata-dev@lists.launchpad.net>
9+- <bigdata@lists.ubuntu.com>
10
11
12 ## Hadoop
13
14=== added directory 'tests'
15=== removed directory 'tests'
16=== removed file 'tests/00-setup'
17--- tests/00-setup 2015-02-16 22:20:57 +0000
18+++ tests/00-setup 1970-01-01 00:00:00 +0000
19@@ -1,8 +0,0 @@
20-#!/bin/bash
21-
22-if ! dpkg -s amulet &> /dev/null; then
23- echo Installing Amulet...
24- sudo add-apt-repository -y ppa:juju/stable
25- sudo apt-get update
26- sudo apt-get -y install amulet
27-fi
28
29=== added file 'tests/01-basic-deployment.py'
30--- tests/01-basic-deployment.py 1970-01-01 00:00:00 +0000
31+++ tests/01-basic-deployment.py 2015-10-06 18:07:13 +0000
32@@ -0,0 +1,24 @@
33+#!/usr/bin/env python3
34+
35+import unittest
36+import amulet
37+
38+
39+class TestDeploy(unittest.TestCase):
40+ """
41+ Trivial deployment test for Apache Hadoop Cliennt.
42+
43+ This charm cannot do anything useful by itself, so integration testing
44+ is done in the bundle.
45+ """
46+
47+ def test_deploy(self):
48+ self.d = amulet.Deployment(series='trusty')
49+ self.d.add('client', 'apache-hadoop-client')
50+ self.d.setup(timeout=900)
51+ self.d.sentry.wait(timeout=1800)
52+ self.unit = self.d.sentry['client'][0]
53+
54+
55+if __name__ == '__main__':
56+ unittest.main()
57
58=== removed file 'tests/01-basic-deployment.py'
59--- tests/01-basic-deployment.py 2015-09-15 17:13:14 +0000
60+++ tests/01-basic-deployment.py 1970-01-01 00:00:00 +0000
61@@ -1,34 +0,0 @@
62-#!/usr/bin/env python3
63-
64-import unittest
65-import amulet
66-
67-
68-class TestDeploy(unittest.TestCase):
69- """
70- Basic deployment test for Apache Hadoop Client.
71-
72- This charm cannot do anything useful by itself, so integration testing
73- is done in the bundle.
74- """
75-
76- @classmethod
77- def setUpClass(cls):
78- cls.d = amulet.Deployment(series='trusty')
79- cls.d.add('apache-hadoop-client')
80- cls.d.setup(timeout=900)
81- cls.d.sentry.wait(timeout=1800)
82- cls.unit = cls.d.sentry.unit['apache-hadoop-client/0']
83-
84- def test_deploy(self):
85- output, retcode = self.unit.run("pgrep -a java")
86- assert 'ResourceManager' not in output, "ResourceManager should not be started"
87- assert 'JobHistoryServer' not in output, "JobHistoryServer should not be started"
88- assert 'NodeManager' not in output, "NodeManager should not be started"
89- assert 'NameNode' not in output, "NameNode should not be started"
90- assert 'SecondaryNameNode' not in output, "SecondaryNameNode should not be started"
91- assert 'DataNode' not in output, "DataServer should not be started"
92-
93-
94-if __name__ == '__main__':
95- unittest.main()
96
97=== added file 'tests/tests.yaml'
98--- tests/tests.yaml 1970-01-01 00:00:00 +0000
99+++ tests/tests.yaml 2015-10-06 18:07:13 +0000
100@@ -0,0 +1,3 @@
101+reset: false
102+packages:
103+ - amulet

Subscribers

People subscribed via source and target branches