Merge lp:~bialix/bzr/2.3-py2exe into lp:bzr/2.3

Proposed by Alexander Belchenko
Status: Merged
Approved by: Andrew Bennetts
Approved revision: no longer in the source branch.
Merged at revision: 5637
Proposed branch: lp:~bialix/bzr/2.3-py2exe
Merge into: lp:bzr/2.3
Diff against target: 40 lines (+11/-1)
2 files modified
doc/en/release-notes/bzr-2.3.txt (+5/-0)
tools/win32/py2exe_boot_common.py (+6/-1)
To merge this branch: bzr merge lp:~bialix/bzr/2.3-py2exe
Reviewer Review Type Date Requested Status
Andrew Bennetts Approve
Gary van der Merwe Approve
John A Meinel Pending
Review via email: mp+55103@code.launchpad.net

Commit message

bzr.exe: add "site-packages" directory to sys.path to allow "installing" third-party libs required by some plugins

Description of the change

bzr.exe: add "site-packages" directory to sys.path to allow "installing" third-party libs required by some plugins

To post a comment you must log in.
Revision history for this message
Alexander Belchenko (bialix) wrote :
Revision history for this message
Gary van der Merwe (garyvdm) :
review: Approve
Revision history for this message
Alexander Belchenko (bialix) wrote :

@Martin Pool: please land this one too. This is backport of the patch https://code.launchpad.net/~bialix/bzr/py2exe/+merge/54999 to 2.3 series. Thank you.

Revision history for this message
Andrew Bennetts (spiv) wrote :

I'm inclined to say we should land this. Although it could be argued to be adding a feature to a stable series, I think it's probably just as fair to argue that it's a bug that it's impossible to install plugins with the py2exe build, and this patch corrects that bug.

Revision history for this message
Andrew Bennetts (spiv) wrote :

Ok, Martin agrees. I'll land it.

Revision history for this message
Andrew Bennetts (spiv) :
review: Approve
Revision history for this message
Andrew Bennetts (spiv) wrote :

sent to pqm by email

Revision history for this message
Alexander Belchenko (bialix) wrote :

Andrew Bennetts пишет:
> Ok, Martin agrees. I'll land it.
Thank you.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/en/release-notes/bzr-2.3.txt'
2--- doc/en/release-notes/bzr-2.3.txt 2011-03-23 11:07:49 +0000
3+++ doc/en/release-notes/bzr-2.3.txt 2011-03-28 08:46:28 +0000
4@@ -48,6 +48,11 @@
5 had changed. Bazaar was attempting to open and lock the master branch
6 twice in this case. (Andrew Bennetts, #733350)
7
8+* Standalone bzr.exe installation on Windows: user can put additional python
9+ libraries into ``site-packages`` subdirectory of the installation directory,
10+ this might be required for "installing" extra dependencies for some plugins.
11+ (Alexander Belchenko, #743256)
12+
13 Documentation
14 *************
15
16
17=== modified file 'tools/win32/py2exe_boot_common.py'
18--- tools/win32/py2exe_boot_common.py 2010-08-02 16:12:01 +0000
19+++ tools/win32/py2exe_boot_common.py 2011-03-28 08:46:28 +0000
20@@ -8,7 +8,6 @@
21
22 import sys
23 if sys.frozen == "windows_exe":
24-
25 class Blackhole(object):
26 softspace = 0
27 def write(self, text):
28@@ -18,6 +17,12 @@
29 sys.stdout = Blackhole()
30 sys.stderr = Blackhole()
31 del Blackhole
32+
33+# add more directories to sys.path to allow "installing" third-party libs
34+# required by some plugins (see bug #743256)
35+import os
36+sys.path.append(os.path.join(os.path.dirname(sys.executable), 'site-packages'))
37+del os
38 del sys
39
40 # Disable linecache.getline() which is called by

Subscribers

People subscribed via source and target branches