Merge lp:~bialix/bzr-colo/lazy-commands into lp:bzr-colo

Proposed by Alexander Belchenko
Status: Merged
Merge reported by: Neil Martinsen-Burrell
Merged at revision: not available
Proposed branch: lp:~bialix/bzr-colo/lazy-commands
Merge into: lp:bzr-colo
Diff against target: 26 lines (+1/-11)
1 file modified
__init__.py (+1/-11)
To merge this branch: bzr merge lp:~bialix/bzr-colo/lazy-commands
Reviewer Review Type Date Requested Status
Neil Martinsen-Burrell Pending
Review via email: mp+17134@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexander Belchenko (bialix) wrote :

This patch fixes lazy commands registration and makes it truly lazy.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Neil, the status of this merge proposal is Merged, but I don't see the changes in lp:bzr-colo branch. Do you merged locally and don't push to lp yet? Or there is something wrong with lp?

Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

On 2010-01-12 02:38 , Alexander Belchenko wrote:
> Neil, the status of this merge proposal is Merged, but I don't see
> the changes in lp:bzr-colo branch. Do you merged locally and don't
> push to lp yet? Or there is something wrong with lp?

Just haven't pushed the changes back to Launchpad. Am doing it now. Peace,

-Neil

Revision history for this message
Alexander Belchenko (bialix) wrote :

Neil Martinsen-Burrell пишет:
> On 2010-01-12 02:38 , Alexander Belchenko wrote:
>> Neil, the status of this merge proposal is Merged, but I don't see
>> the changes in lp:bzr-colo branch. Do you merged locally and don't
>> push to lp yet? Or there is something wrong with lp?
>
> Just haven't pushed the changes back to Launchpad. Am doing it now. Peace,

In this case I suggest to not change status to Merged manually.
LP is smart enough to detect the moment when the merge proposal will land to lp branch and mark it
as Merged automatically.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2010-01-10 19:57:10 +0000
3+++ __init__.py 2010-01-11 10:39:16 +0000
4@@ -68,15 +68,6 @@
5 from bzrlib.help_topics import topic_registry
6
7 from info import bzr_plugin_version as version_info
8-from commands import (cmd_colo_init,
9- cmd_colo_branch,
10- cmd_colo_branches,
11- cmd_colo_fetch,
12- cmd_colo_clone,
13- cmd_colo_prune,
14- cmd_colo_clean,
15- cmd_colo_ify
16- )
17 from colocated import ColocatedDirectory
18 from tutorial import _colo_tutorial
19
20@@ -102,5 +93,4 @@
21 ('cmd_colo_ify', []),
22 ]
23 for cmd, aliases in lazy_commands:
24- plugin_cmds.register_lazy(cmd, aliases, 'bzrlib.plugins.colo')
25-
26+ plugin_cmds.register_lazy(cmd, aliases, 'bzrlib.plugins.colo.commands')

Subscribers

People subscribed via source and target branches