Merge lp:~bhdouglass/rockwork/configuration-fix into lp:rockwork

Proposed by Brian Douglass
Status: Merged
Merged at revision: 63
Proposed branch: lp:~bhdouglass/rockwork/configuration-fix
Merge into: lp:rockwork
Prerequisite: lp:~bhdouglass/rockwork/jskit
Diff against target: 35 lines (+2/-6)
2 files modified
rockwork/AppSettingsPage.qml (+0/-4)
rockworkd/libpebble/jskit/jskitmanager.cpp (+2/-2)
To merge this branch: bzr merge lp:~bhdouglass/rockwork/configuration-fix
Reviewer Review Type Date Requested Status
Michael Zanetti Pending
Review via email: mp+285269@code.launchpad.net

This proposal supersedes a proposal from 2016-02-06.

Description of the change

This also includes all the jskit changes from the jskit merge request.

This fixes the evernote configuration problem, but the evernote app keeps having syncing issues. I'm not totally convinced this is RockWork's fault as it sometimes is successful.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rockwork/AppSettingsPage.qml'
2--- rockwork/AppSettingsPage.qml 2016-01-03 05:06:13 +0000
3+++ rockwork/AppSettingsPage.qml 2016-02-06 16:23:43 +0000
4@@ -42,10 +42,6 @@
5 request.action = Oxide.NavigationRequest.ActionReject;
6 pageStack.pop();
7 }
8- else {
9- Qt.openUrlExternally(url);
10- request.action = Oxide.NavigationRequest.ActionReject;
11- }
12 }
13
14 Component.onCompleted: {
15
16=== modified file 'rockworkd/libpebble/jskit/jskitmanager.cpp'
17--- rockworkd/libpebble/jskit/jskitmanager.cpp 2016-02-06 16:23:42 +0000
18+++ rockworkd/libpebble/jskit/jskitmanager.cpp 2016-02-06 16:23:43 +0000
19@@ -1,5 +1,6 @@
20 #include <QFile>
21 #include <QDir>
22+#include <QUrl>
23
24 #include "jskitmanager.h"
25 #include "jskitpebble.h"
26@@ -57,8 +58,7 @@
27 {
28 if (m_engine) {
29 QJSValue eventObj = m_engine->newObject();
30- QByteArray data = QByteArray::fromPercentEncoding(result.toUtf8());
31- eventObj.setProperty("response", m_engine->toScriptValue(data));
32+ eventObj.setProperty("response", QUrl::fromPercentEncoding(result.toUtf8()));
33
34 qCDebug(l) << "Sending" << eventObj.property("response").toString();
35 m_jspebble->invokeCallbacks("webviewclosed", QJSValueList({eventObj}));

Subscribers

People subscribed via source and target branches