Merge lp:~bhavi/uak/add-locoteam-approval into lp:uak
| Status: | Merged |
|---|---|
| Merged at revision: | 63 |
| Proposed branch: | lp:~bhavi/uak/add-locoteam-approval |
| Merge into: | lp:uak |
| Diff against target: |
210 lines (+171/-1) 4 files modified
adk/documentation.rst (+1/-0) adk/locoteams-approval.rst (+149/-0) adk/locoteams-running.rst (+15/-1) debian/changelog (+6/-0) |
| To merge this branch: | bzr merge lp:~bhavi/uak/add-locoteam-approval |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jono Bacon (community) | 2012-12-16 | Approve on 2012-12-17 | |
|
Review via email:
|
|||
Description of the Change
Added a note on getting a loco team approved in /adk/locoteams-
Regards
Bhavani
| Javier López (javier-lopez) wrote : | # |
It has a typo:
"Over a period of time you can you can apply for approval from the LoCo Council." -> you can
I agree with the comment Jono made, I'd be glad to help you Bhavani, my english isn't very good, but I think I understand at least basically the process.
| Bhavani Shankar (bhavi) wrote : | # |
> Thanks for the contribution, Bhavani!
>
> I think this is a great start, but I think we should create a new page that
> outlines the approval process. This way you can explain:
>
> * the difference between Approved and non-Approved teams.
> * why teams should strive to be approved.
> * how the approval process works.
> * some tips and tricks for ensuring teams are successful.
>
> Could you create locoteams-
> re-submit? Thanks!
Thanks Jono! and Javier for pointing out the typo, I'll work on the same and resubmit this evening.
Regards
Bhavani
- 61. By Bhavani Shankar on 2012-12-17
-
Added adk/locoteams-
approval. rst containing lococouncil processes on approval - 62. By Bhavani Shankar on 2012-12-17
-
Update the d/changelog
| Bhavani Shankar (bhavi) wrote : | # |
Dear Jono,
Updated the branch
Regards
Bhavani
- 63. By Bhavani Shankar on 2012-12-17
-
Few more markup changes
- 64. By Bhavani Shankar on 2012-12-17
-
fix typos
| Bhavani Shankar (bhavi) wrote : | # |
Dear Jono,
Please review latest commit 64 as I have done few more markup changes and fixed typos
Regards
Bhavani
- 65. By Bhavani Shankar on 2012-12-17
-
make reference to locoteams-approval in /adk/documentat
ion.rst
| Bhavani Shankar (bhavi) wrote : | # |
Referenced locoteams-
Regards
Bhavani
- 66. By Bhavani Shankar on 2012-12-17
-
Bit more rewording :-) Thanks to Chris and Sergio
| Jono Bacon (jonobacon) wrote : | # |
Thanks for the update, guys! Great work, and thanks for the contribution!
I made some edits that you can see in trunk now that I would like to ask you to bear in mind for future contributions:
* There were some spelling mistakes - please run a spellcheck before you submit.
* I used different heading levels to add sections within other sections.
* Try not to talk about the document itself (e.g. purpose of the document) and just present the information.
* I made some of the content a little more concise - people won't read huge chunks of text.
* There were some bits where the writing didn't make sense (I suspect this is because English is not your first language) - it might be wise to ask a native English speaker to proof read your content to help with this.
Thanks again for the contribution and I hope this feedback helps and you continue to contribute! :-)
| Bhavani Shankar (bhavi) wrote : | # |
Thanks Jono for going through the review. We will get the help of a native speaker at the time of submission.
Regards
Bhavani

Thanks for the contribution, Bhavani!
I think this is a great start, but I think we should create a new page that outlines the approval process. This way you can explain:
* the difference between Approved and non-Approved teams.
* why teams should strive to be approved.
* how the approval process works.
* some tips and tricks for ensuring teams are successful.
Could you create locoteams- approvalprocess .rst and add this content and then re-submit? Thanks!