Merge lp:~bhavesh-goyal093/postorius/postorius-list_nav-fix into lp:postorius

Proposed by Bhavesh Goyal
Status: Needs review
Proposed branch: lp:~bhavesh-goyal093/postorius/postorius-list_nav-fix
Merge into: lp:postorius
Diff against target: 45 lines (+8/-5)
3 files modified
src/postorius/static/postorius/css/style.css (+3/-0)
src/postorius/templates/postorius/lists/memberoptions.html (+1/-1)
src/postorius/templates/postorius/user_subscription_preferences.html (+4/-4)
To merge this branch: bzr merge lp:~bhavesh-goyal093/postorius/postorius-list_nav-fix
Reviewer Review Type Date Requested Status
Terri Disapprove
Review via email: mp+252064@code.launchpad.net

Description of the change

Fixed Postorius Bug #1428966 which caused member options page to show up unwanted piece of info in list_nav. The fix has been made by adding an empty space to the nav address instead of a null string which caused the bug to arise.
Now the postorius UI is updated and looks better overall.

To post a comment you must log in.
Revision history for this message
Terri (terriko) wrote :

I believe this bug has already been fixed, so this patch is redundant now.

review: Disapprove

Unmerged revisions

206. By Bhavesh Goyal

Fixed Bug #1428966 which fixes postorius UI

205. By Bhavesh Goyal

Fixed postorius Bug #1428646 which updates the UI of Mailing list forms

204. By Bhavesh Goyal

Fixed UI Bug which had unaligned radio buttons in subsricption preferences tab

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/static/postorius/css/style.css'
2--- src/postorius/static/postorius/css/style.css 2015-02-06 15:50:56 +0000
3+++ src/postorius/static/postorius/css/style.css 2015-03-06 07:22:15 +0000
4@@ -212,6 +212,9 @@
5 }
6
7 /* auto-generated forms made a bit cleaner */
8+.well {
9+ width: 100%;
10+}
11 .well label {
12 display: inline;
13 }
14
15=== modified file 'src/postorius/templates/postorius/lists/memberoptions.html'
16--- src/postorius/templates/postorius/lists/memberoptions.html 2015-01-09 14:40:06 +0000
17+++ src/postorius/templates/postorius/lists/memberoptions.html 2015-03-06 07:22:15 +0000
18@@ -4,7 +4,7 @@
19 {% load nav_helpers %}
20
21 {% block main %}
22- {% list_nav '' '' %}
23+ {% list_nav '' ' ' %}
24
25 {% if not user.is_superuser or not user.is_list_owner %}
26 <div class="mm_subHeader" >
27
28=== modified file 'src/postorius/templates/postorius/user_subscription_preferences.html'
29--- src/postorius/templates/postorius/user_subscription_preferences.html 2015-01-09 16:07:56 +0000
30+++ src/postorius/templates/postorius/user_subscription_preferences.html 2015-03-06 07:22:15 +0000
31@@ -37,10 +37,10 @@
32 <td style="width:10%">{{subscription.list_id}}</td>
33 <td style="width:14%">{{form.delivery_status}}</td>
34 <td style="width:20%">{{form.delivery_mode}}</td>
35- <td style="width:14%">{{form.receive_own_postings}}</td>
36- <td style="width:14%">{{form.acknowledge_posts}}</td>
37- <td style="width:14%">{{form.hide_address}}</td>
38- <td style="width:14%">{{form.receive_list_copy}}</td>
39+ <td style="width:14%"><ul><li>{{form.receive_own_postings}}</li></ul></td>
40+ <td style="width:14%"><ul><li>{{form.acknowledge_posts}}</li></ul></td>
41+ <td style="width:14%"><ul><li>{{form.hide_address}}</li></ul></td>
42+ <td style="width:14%"><ul><li>{{form.receive_list_copy}}</li></ul></td>
43 </tr>
44 {% endfor %}
45 </table>

Subscribers

People subscribed via source and target branches