Merge lp:~bhavesh-goyal093/postorius/fixed-invalid-email-acceptance into lp:postorius
Proposed by
Bhavesh Goyal
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 216 | ||||
Proposed branch: | lp:~bhavesh-goyal093/postorius/fixed-invalid-email-acceptance | ||||
Merge into: | lp:postorius | ||||
Diff against target: |
49 lines (+13/-14) 1 file modified
src/postorius/views/list.py (+13/-14) |
||||
To merge this branch: | bzr merge lp:~bhavesh-goyal093/postorius/fixed-invalid-email-acceptance | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Terri | Approve | ||
Review via email: mp+255447@code.launchpad.net |
Description of the change
Earlier The Mass Subscription also allowed some invalid email addresses such as ..<email address hidden>, ...@gmail.com to get subscribed to a mailing list, which could have led to Server Errors in long run while sending mass mails.
Now The Emails are successfully validated using Django EmailValidators and all the invalid emails including the ones ignored earlier are now rejected by throwing a Email Validation Error.
To post a comment you must log in.
I *think* that invalid email addresses are probably rejected by Mailman Core anyhow, but this should let us provide better error messages. I'm running some tests against the code now in preparation for merging.
If someone could set up a few tox tests for this so it'll be tested going forwards, that would be most excellent.