Merge lp:~bhavesh-goyal093/postorius/feature-added-search-postorius-lists into lp:postorius

[Bhavesh Goyal]

Search is regarded as an important function for any list. The postorius lists earlier had no such function in members list page. Thus for large lists, it was difficult for list maintainer to search for a particular member in such lists. Even with Find In Page Browser function, it doesn't allow to search among whole lists across different pages and just highlights the results merely reducing the effort of going through the whole list.

Now The Members list can be filtered based on email address and certain functions such as getting all addresses starting with certain keywords and getting addresses containing some specific keywords can also be performed using the search box implemented in members list page.

[Terri (terriko)]

This looks like a useful feature, but I believe this needs some more careful validation of the search string. Could you double-check that you're following best practices since the search string is being displayed in the page?

review: Needs Fixing

[lp:~bhavesh-goyal093/postorius/feature-added-search-postorius-lists]

209. By Bhavesh Goyal on 2015-04-15

Improved Indentations

210. By Bhavesh Goyal on 2015-04-15

Merged Updations

211. By Bhavesh Goyal on 2015-04-15

pep8 minor fixes

212. By Bhavesh Goyal on 2015-04-15

Added Page Titles for Mass Removal

213. By Bhavesh Goyal on 2015-04-15

Sanitization for form input data

214. By Bhavesh Goyal on 2015-04-15

Merged Updations

Unmerged revisions

214. By Bhavesh Goyal on 2015-04-15

Merged Updations

213. By Bhavesh Goyal on 2015-04-15

Sanitization for form input data

212. By Bhavesh Goyal on 2015-04-15

Added Page Titles for Mass Removal

211. By Bhavesh Goyal on 2015-04-15

pep8 minor fixes

210. By Bhavesh Goyal on 2015-04-15

Merged Updations

209. By Bhavesh Goyal on 2015-04-15

Improved Indentations

208. By Bhavesh Goyal on 2015-03-09

Feature Implemented: Added Search Functionality in postorius Members List

207. By Bhavesh Goyal on 2015-03-07

Fixed Bug #1428646 (Updated Subscription Settings Forms UI)

206. By Bhavesh Goyal on 2015-03-06

Fixed Bug #1428966 which fixes postorius UI

205. By Bhavesh Goyal on 2015-03-05

Fixed postorius Bug #1428646 which updates the UI of Mailing list forms

=== modified file 'src/postorius/forms.py'
--- src/postorius/forms.py	2015-04-15 21:48:46 +0000
+++ src/postorius/forms.py	2015-04-15 23:31:33 +0000
@@ -91,6 +91,15 @@
             'required': _('Please enter an email adddress.'),
             'invalid': _('Please enter a valid email adddress.')})
 
+class NewMemberSearchForm(forms.Form):
+
+    """Search Among the list Members."""
+    search_name = forms.CharField(
+        label=_('Search Member Name'),
+        required=True,
+        error_messages={
+            'required': _('Please enter a name for the member to be searched'),
+            'invalid': _('Please enter a valid name')})
 
 class ListNew(FieldsetForm):
 

=== modified file 'src/postorius/static/postorius/css/style.css'
--- src/postorius/static/postorius/css/style.css	2015-04-15 14:32:15 +0000
+++ src/postorius/static/postorius/css/style.css	2015-04-15 23:31:33 +0000
@@ -192,6 +192,9 @@
 .btn {
     border-radius: 2px;
 }
+.clear {
+    margin-left: 0.2em;
+}
 
 /* tables */
 .table .mm_action {

=== modified file 'src/postorius/templates/postorius/lists/confirm_removeall_subscribers.html'
--- src/postorius/templates/postorius/lists/confirm_removeall_subscribers.html	2015-03-22 21:57:28 +0000
+++ src/postorius/templates/postorius/lists/confirm_removeall_subscribers.html	2015-04-15 23:31:33 +0000
@@ -1,6 +1,11 @@
 {% extends "postorius/base.html" %}
 {% load url from future %}
 {% load i18n %}
+
+{% block subtitle %}
+{% trans "Confirm Unsubscribe All | " as page_title %}{{ page_title|add:address}}
+{% endblock %}
+
 {% load nav_helpers %}
 
 {% block main %}

=== modified file 'src/postorius/templates/postorius/lists/mass_removal.html'
--- src/postorius/templates/postorius/lists/mass_removal.html	2015-04-13 22:57:55 +0000
+++ src/postorius/templates/postorius/lists/mass_removal.html	2015-04-15 23:31:33 +0000
@@ -1,6 +1,11 @@
 {% extends postorius_base_template %}
 {% load url from future %}
 {% load i18n %}
+
+{% block subtitle %}
+{% trans "Mass Removal | "%}{{ page_title|add:list.fqdn_listname}}
+{% endblock %}
+
 {% load nav_helpers %}
 
 {% block main %}

=== modified file 'src/postorius/templates/postorius/lists/members.html'
--- src/postorius/templates/postorius/lists/members.html	2015-04-15 21:48:46 +0000
+++ src/postorius/templates/postorius/lists/members.html	2015-04-15 23:31:33 +0000
@@ -65,6 +65,15 @@
     </table>
 
     <h2>{% trans "Members" %}</h2>
+    
+    <form style="float:left" action="{% url 'list_members' list.fqdn_listname %}" method="POST" class="form-inline" >{% csrf_token %}
+        {{ search_form.search_name }}   
+	<button type="submit" class="btn">{% trans 'Search' %}</button>
+    </form>
+    <form action="{% url 'list_members' list.fqdn_listname %}" method="POST" class="form-inline">{% csrf_token %}
+        <button type="submit" class="btn clear">{% trans 'Clear Filter' %}</button>
+    </form>
+    
     <table class="table table-bordered table-striped">
         <thead>
     		<tr>
@@ -74,7 +83,7 @@
     		</tr>
         </thead>
     	<tbody>
-            {% for member in list.member_page %}
+            {% for member in search_res %}
                 <tr>
                     <td> <a href="{% url 'list_member_options' list.fqdn_listname member.email %}">
                         {{ member.email }}</a></td>

=== modified file 'src/postorius/views/list.py'
--- src/postorius/views/list.py	2015-04-15 22:34:24 +0000
+++ src/postorius/views/list.py	2015-04-15 23:31:33 +0000
@@ -26,6 +26,7 @@
 from django.core.validators import validate_email
 from django.core.exceptions import ValidationError
 from django.utils.decorators import method_decorator
+from django.utils.html import strip_tags, escape
 from django.utils.translation import gettext as _
 from urllib2 import HTTPError
 
@@ -77,22 +78,51 @@
                                    % request.POST['moderator_email']))
                 except HTTPError as e:
                     messages.error(request, _(e.msg))
+        if 'search_name' in request.POST:
+            search_form = NewMemberSearchForm(request.POST)
+            if search_form.is_valid():
+                res = []
+                mlist = self._get_list(list_id, page)
+                for names in mlist.member_page:
+                    query = strip_tags(escape(request.POST['search_name']))
+                    if names.email.find(query) != -1:
+                        res.append(names)
+                try:
+                        if len(res) == 0:
+                            messages.success(
+                            request, _('No Result Found for string \' %s \'.' % query))
+                        else:
+                            messages.success(
+                            request, _('Found %s member(s) containing string \' %s \'.' % (len(res), query)))
+                except HTTPError as e:
+                    messages.error(request, _(e.msg))
+        try:
+            res
+        except UnboundLocalError as e:
+            res = self._get_list(list_id, page).member_page
         owner_form = NewOwnerForm()
         moderator_form = NewModeratorForm()
+        search_form = NewMemberSearchForm()
         return render_to_response('postorius/lists/members.html',
                                   {'list': self.mailing_list,
                                    'owner_form': owner_form,
-                                   'moderator_form': moderator_form},
+                                   'moderator_form': moderator_form,
+                                   'search_form': search_form,
+                                   'search_res': res},
                                   context_instance=RequestContext(request))
 
     @method_decorator(list_owner_required)
     def get(self, request, list_id, page=1):
         owner_form = NewOwnerForm()
         moderator_form = NewModeratorForm()
+        search_form = NewMemberSearchForm()
+        res = self._get_list(list_id, page).member_page
         return render_to_response('postorius/lists/members.html',
                                   {'list': self.mailing_list,
                                    'owner_form': owner_form,
-                                   'moderator_form': moderator_form},
+                                   'moderator_form': moderator_form,
+                                   'search_form': search_form,
+                                   'search_res': res},
                                   context_instance=RequestContext(request))