Merge lp:~bgh/nova/ubuntu into lp:~openstack-ubuntu-packagers/nova/ubuntu

Proposed by Brad Hall
Status: Needs review
Proposed branch: lp:~bgh/nova/ubuntu
Merge into: lp:~openstack-ubuntu-packagers/nova/ubuntu
Diff against target: 13 lines (+3/-1)
1 file modified
debian/nova_sudoers (+3/-1)
To merge this branch: bzr merge lp:~bgh/nova/ubuntu
Reviewer Review Type Date Requested Status
OpenStack Ubuntu packagers Pending
Review via email: mp+80969@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

this could probably be a separate bug but I just noticed the arping line is wrong.
It says:

/usr/bin/arping

but on ubuntu it should be:

/usr/sbin/arping

Might be useful to change that while you are editing the line.

Revision history for this message
Brad Hall (bgh) wrote :

Looks like that depends on whether you install iputils-arping or arping .. for some reason on my oneiric machine iputils-arping got installed (/usr/bin/arping). On natty the arping package is installed (/usr/sbin/arping). Anyhow, I'll update the merge prop as we probably want to use the arping package anyways (as opposed to iputils-arping).

lp:~bgh/nova/ubuntu updated
196. By Brad Hall

Change arping location

If you install the "arping" package on ubuntu, arping will land in /usr/sbin.
However, if you install iputils-arping, then arping will land in /usr/bin. I
think we want the one from the arping package and not iputils.

Unmerged revisions

196. By Brad Hall

Change arping location

If you install the "arping" package on ubuntu, arping will land in /usr/sbin.
However, if you install iputils-arping, then arping will land in /usr/bin. I
think we want the one from the arping package and not iputils.

195. By Brad Hall

Add ovs-vsctl and tunctl to the sudoers comand

This fixes launchpad bug: 882568

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/nova_sudoers'
2--- debian/nova_sudoers 2011-09-20 14:09:55 +0000
3+++ debian/nova_sudoers 2011-11-16 18:49:27 +0000
4@@ -41,7 +41,9 @@
5 /usr/bin/socat, \
6 /sbin/parted, \
7 /usr/sbin/dnsmasq, \
8- /usr/bin/arping
9+ /usr/sbin/arping, \
10+ /usr/sbin/tunctl, \
11+ /usr/bin/ovs-vsctl
12
13 nova ALL = (root) NOPASSWD: SETENV: NOVACMDS
14

Subscribers

People subscribed via source and target branches