Merge lp:~bfiller/webbrowser-app/skip-tabs-test into lp:webbrowser-app

Proposed by Bill Filler
Status: Merged
Approved by: Omer Akram
Approved revision: 231
Merged at revision: 231
Proposed branch: lp:~bfiller/webbrowser-app/skip-tabs-test
Merge into: lp:webbrowser-app
Diff against target: 28 lines (+3/-1)
1 file modified
tests/autopilot/webbrowser_app/tests/test_tabs.py (+3/-1)
To merge this branch: bzr merge lp:~bfiller/webbrowser-app/skip-tabs-test
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Omer Akram (community) Approve
Review via email: mp+175926@code.launchpad.net

Commit message

skip close tab tests

Description of the change

skip close tab tests

To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/webbrowser_app/tests/test_tabs.py'
2--- tests/autopilot/webbrowser_app/tests/test_tabs.py 2013-07-04 15:12:39 +0000
3+++ tests/autopilot/webbrowser_app/tests/test_tabs.py 2013-07-19 19:01:33 +0000
4@@ -12,7 +12,7 @@
5 from autopilot.matchers import Eventually
6
7 from webbrowser_app.tests import StartOpenRemotePageTestCaseBase
8-
9+import unittest
10
11 class TestTabs(StartOpenRemotePageTestCaseBase):
12
13@@ -114,6 +114,7 @@
14 self.assertThat(activity_view.visible, Eventually(Equals(False)))
15 self.assert_chrome_eventually_hidden()
16
17+ @unittest.skip("skipping, tab close not implemented per design")
18 def test_close_tab(self):
19 self.ensure_activity_view_visible()
20 self.open_new_tab()
21@@ -132,6 +133,7 @@
22 self.assertThat(view.currentIndex, Eventually(Equals(0)))
23 self.assert_current_url(url)
24
25+ @unittest.skip("skipping, tab close not implemented per design")
26 def test_close_last_open_tab(self):
27 self.ensure_activity_view_visible()
28 self.close_tab(0)

Subscribers

People subscribed via source and target branches

to status/vote changes: