Merge lp:~bfiller/unity8/fix-password-autocaps into lp:unity8

Proposed by Bill Filler
Status: Merged
Approved by: MichaƂ Sawicz
Approved revision: 582
Merged at revision: 606
Proposed branch: lp:~bfiller/unity8/fix-password-autocaps
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
Notifications/NotificationMenuItemFactory.qml (+1/-0)
To merge this branch: bzr merge lp:~bfiller/unity8/fix-password-autocaps
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Nicolas d'Offay (community) Approve
Review via email: mp+198319@code.launchpad.net

Commit message

fix for lp:1259294, turn off auto capitalization for wifi password field

Description of the change

Set the inputMethodHint: Qt.ImhNoAutoUppercase for the wifi password field so the auto capitalization is disabled even when the show password checkbox is enabled.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:582
http://jenkins.qa.ubuntu.com/job/unity8-ci/1847/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1541
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1496
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/604
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/370
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/371
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/371/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/370
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1370
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1541
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1541/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1496
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1496/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4025
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2185

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1847/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

Tested, seems good to me.

Revision history for this message
Nicolas d'Offay (nicolas-doffay) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/890/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3734
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1927
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1843/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/751
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/276
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/276
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/276/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/276
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1698
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1927
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1927/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1843
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1843/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4316/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2588

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/891/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/generic-cleanup-mbs/3735
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1930
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1845/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/753
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/277
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/277
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/277/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/277
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1700
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1930
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1930/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1845
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1845/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4317/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2589

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Notifications/NotificationMenuItemFactory.qml'
2--- Notifications/NotificationMenuItemFactory.qml 2013-11-08 01:38:29 +0000
3+++ Notifications/NotificationMenuItemFactory.qml 2013-12-09 21:37:04 +0000
4@@ -65,6 +65,7 @@
5 TextField {
6 id: textfield
7
8+ inputMethodHints: Qt.ImhNoAutoUppercase
9 anchors.left: parent.left; anchors.right: parent.right
10 echoMode: checkBox.checked ? TextInput.Normal : TextInput.Password
11 height: units.gu(5)

Subscribers

People subscribed via source and target branches