Merge lp:~bfiller/unity8/disable-predictive-text into lp:unity8

Proposed by Bill Filler
Status: Merged
Approved by: Michał Sawicz
Approved revision: 653
Merged at revision: 659
Proposed branch: lp:~bfiller/unity8/disable-predictive-text
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
qml/Components/PageHeader.qml (+1/-0)
To merge this branch: bzr merge lp:~bfiller/unity8/disable-predictive-text
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity Team Pending
Review via email: mp+203390@code.launchpad.net

Commit message

disable predictive text in Dash search field as it interferes with built-in search

Description of the change

1) Are there any related MPs required for this MP to build/function as expected? Please list.: NO

2) Did you perform an exploratory manual test run of your code change and any related functionality? Yes, I enabled/disabled predictive text and made sure word ribbon did not show up in unity search bar
3) If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP? : no packaging changes
4) If you changed the UI, has there been a design review? The UI has not been modified

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:653
http://jenkins.qa.ubuntu.com/job/unity8-ci/2132/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2635
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2425
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1005
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/654
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/656
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/656/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/654
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2307
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2637
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2637/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2426
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2426/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4866
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3378

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2132/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :
Revision history for this message
Michał Sawicz (saviq) wrote :

Please answer the questions in the description, as per https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8

Revision history for this message
Michał Sawicz (saviq) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality?
* Yes, works as expected.

Did CI run pass? If not, please explain why.
* One ap failure, known and being worked on.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Components/PageHeader.qml'
2--- qml/Components/PageHeader.qml 2014-01-07 15:15:18 +0000
3+++ qml/Components/PageHeader.qml 2014-01-27 18:14:00 +0000
4@@ -145,6 +145,7 @@
5 anchors.fill: parent
6 anchors.margins: units.gu(1)
7
8+ inputMethodHints: Qt.ImhNoPredictiveText
9 hasClearButton: false
10
11 primaryItem: AbstractButton {

Subscribers

People subscribed via source and target branches