Merge lp:~bfiller/unity8/add-new-telephony into lp:unity8

Proposed by Bill Filler
Status: Superseded
Proposed branch: lp:~bfiller/unity8/add-new-telephony
Merge into: lp:unity8
Diff against target: 127 lines (+57/-21)
2 files modified
Dash/Apps/FrequentlyUsedAppsModel.qml (+40/-10)
plugins/Unity/Launcher/backend/launcherbackend.cpp (+17/-11)
To merge this branch: bzr merge lp:~bfiller/unity8/add-new-telephony
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+182162@code.launchpad.net

This proposal has been superseded by a proposal from 2013-08-26.

Commit message

add new telephony apps (dialer, messaging, contacts) to launcher and Home scope. Reverse order of launcher icons so most frequent are at top so they are visible by default

Description of the change

add new telephony apps (dialer, messaging, contacts) to launcher and Home scope. Reverse order of launcher icons so most frequent are at top so they are visible by default

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Note that on the phone, the launcher starts up unfolded at the bottom, folding the top-most icons (Also inverting the order of the icons compared to the Desktop). The reason for this is to have important items easily reachable with the thumb while putting the others far away to the top.

review: Needs Fixing
lp:~bfiller/unity8/add-new-telephony updated
250. By Bill Filler

revert order of launcher icons to original order

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Dash/Apps/FrequentlyUsedAppsModel.qml'
2--- Dash/Apps/FrequentlyUsedAppsModel.qml 2013-08-20 22:29:48 +0000
3+++ Dash/Apps/FrequentlyUsedAppsModel.qml 2013-08-26 17:06:27 +0000
4@@ -18,6 +18,36 @@
5
6 ListModel {
7 ListElement {
8+ uri: "application:///usr/share/applications/dialer-app.desktop"
9+ icon: "../../graphics/applicationIcons/phone-app.png"
10+ category: 0
11+ mimetype: "application/x-desktop"
12+ title: "Dialer"
13+ comment: ""
14+ dndUri: "file:///usr/share/applications/dialer-app.desktop"
15+ metadata: ""
16+ }
17+ ListElement {
18+ uri: "application:///usr/share/applications/messaging-app.desktop"
19+ icon: "../../graphics/applicationIcons/messages-app.png"
20+ category: 0
21+ mimetype: "application/x-desktop"
22+ title: "Messaging"
23+ comment: ""
24+ dndUri: "file:///usr/share/applications/messaging-app.desktop"
25+ metadata: ""
26+ }
27+ ListElement {
28+ uri: "application:///usr/share/applications/address-book-app.desktop"
29+ icon: "../../graphics/applicationIcons/contacts-app.png"
30+ category: 0
31+ mimetype: "application/x-desktop"
32+ title: "Contacts"
33+ comment: ""
34+ dndUri: "file:///usr/share/applications/address-book-app.desktop"
35+ metadata: ""
36+ }
37+ ListElement {
38 uri: "application:///usr/share/applications/camera-app.desktop"
39 icon: "../../graphics/applicationIcons/camera.png"
40 category: 0
41@@ -28,16 +58,6 @@
42 metadata: ""
43 }
44 ListElement {
45- uri: "application:///usr/share/applications/phone-app.desktop"
46- icon: "../../graphics/applicationIcons/phone-app.png"
47- category: 0
48- mimetype: "application/x-desktop"
49- title: "Phone"
50- comment: ""
51- dndUri: "file:///usr/share/applications/phone-app.desktop"
52- metadata: ""
53- }
54- ListElement {
55 uri: "application:///usr/share/applications/gallery-app.desktop"
56 icon: "../../graphics/applicationIcons/gallery.png"
57 category: 0
58@@ -77,4 +97,14 @@
59 dndUri: "file:///usr/share/applications/gmail-webapp.desktop"
60 metadata: ""
61 }
62+ ListElement {
63+ uri: "application:///usr/share/applications/ubuntu-system-settings.desktop"
64+ icon: "../../graphics/applicationIcons/system-settings.png"
65+ category: 0
66+ mimetype: "application/x-desktop"
67+ title: "System Settings"
68+ comment: ""
69+ dndUri: "file:///usr/share/applications/ubuntu-system-settings.desktop"
70+ metadata: ""
71+ }
72 }
73
74=== added file 'graphics/applicationIcons/contacts-app@18.png'
75Binary files graphics/applicationIcons/contacts-app@18.png 1970-01-01 00:00:00 +0000 and graphics/applicationIcons/contacts-app@18.png 2013-08-26 17:06:27 +0000 differ
76=== added file 'graphics/applicationIcons/messages-app@18.png'
77Binary files graphics/applicationIcons/messages-app@18.png 1970-01-01 00:00:00 +0000 and graphics/applicationIcons/messages-app@18.png 2013-08-26 17:06:27 +0000 differ
78=== added file 'graphics/applicationIcons/system-settings@18.png'
79Binary files graphics/applicationIcons/system-settings@18.png 1970-01-01 00:00:00 +0000 and graphics/applicationIcons/system-settings@18.png 2013-08-26 17:06:27 +0000 differ
80=== modified file 'plugins/Unity/Launcher/backend/launcherbackend.cpp'
81--- plugins/Unity/Launcher/backend/launcherbackend.cpp 2013-08-16 11:41:27 +0000
82+++ plugins/Unity/Launcher/backend/launcherbackend.cpp 2013-08-26 17:06:27 +0000
83@@ -28,19 +28,23 @@
84 // TODO: load default pinned ones from default config, instead of hardcoding here...
85
86 m_storedApps <<
87- QLatin1String("phone-app.desktop") <<
88+ QLatin1String("calendar-app.desktop") <<
89+ QLatin1String("notes-app.desktop") <<
90+ QLatin1String("ubuntu-weather-app.desktop") <<
91+ QLatin1String("gmail-webapp.desktop") <<
92+ QLatin1String("twitter-webapp.desktop") <<
93+ QLatin1String("webbrowser-app.desktop") <<
94+ QLatin1String("facebook-webapp.desktop") <<
95+ QLatin1String("gallery-app.desktop") <<
96 QLatin1String("camera-app.desktop") <<
97- QLatin1String("gallery-app.desktop") <<
98- QLatin1String("facebook-webapp.desktop") <<
99- QLatin1String("webbrowser-app.desktop") <<
100- QLatin1String("twitter-webapp.desktop") <<
101- QLatin1String("gmail-webapp.desktop") <<
102- QLatin1String("ubuntu-weather-app.desktop") <<
103- QLatin1String("notes-app.desktop") <<
104- QLatin1String("calendar-app.desktop");
105+ QLatin1String("address-book-app.desktop") <<
106+ QLatin1String("messaging-app.desktop") <<
107+ QLatin1String("dialer-app.desktop");
108
109 // TODO: get stuff from desktop files instead this hardcoded map
110- m_displayNameMap.insert("phone-app.desktop", "Phone");
111+ m_displayNameMap.insert("dialer-app.desktop", "Dialer");
112+ m_displayNameMap.insert("messaging-app.desktop", "Messaging");
113+ m_displayNameMap.insert("address-book-app.desktop", "Contacts");
114 m_displayNameMap.insert("camera-app.desktop", "Camera");
115 m_displayNameMap.insert("gallery-app.desktop", "Gallery");
116 m_displayNameMap.insert("facebook-webapp.desktop", "Facebook");
117@@ -52,7 +56,9 @@
118 m_displayNameMap.insert("calendar-app.desktop", "Calendar");
119
120 // TODO: get stuff from desktop files instead this hardcoded map
121- m_iconMap.insert("phone-app.desktop", "phone-app");
122+ m_iconMap.insert("dialer-app.desktop", "phone-app");
123+ m_iconMap.insert("messaging-app.desktop", "messages-app");
124+ m_iconMap.insert("address-book-app.desktop", "contacts-app");
125 m_iconMap.insert("camera-app.desktop", "camera");
126 m_iconMap.insert("gallery-app.desktop", "gallery");
127 m_iconMap.insert("facebook-webapp.desktop", "facebook");

Subscribers

People subscribed via source and target branches