Ubuntu UI Toolkit Extras

Merge lp:~bfiller/ubuntu-ui-extras/share_icon into lp:ubuntu-ui-extras

  1. share_icon
  2. Merge into trunk
Proposed by Bill Filler
Status: Merged
Approved by: Bill Filler
Approved revision: 56
Merged at revision: 56
Proposed branch: lp:~bfiller/ubuntu-ui-extras/share_icon
Merge into: lp:ubuntu-ui-extras
Diff against target: 16 lines (+3/-1)
1 file modified
modules/Ubuntu/Components/Extras/Share.qml (+3/-1)
To merge this branch: bzr merge lp:~bfiller/ubuntu-ui-extras/share_icon
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Review via email: mp+207985@code.launchpad.net

Commit message

fix facebook icon not appearing

Description of the change

fix facebook icon not appearing

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Extras/Share.qml'
2--- modules/Ubuntu/Components/Extras/Share.qml 2013-08-29 13:14:08 +0000
3+++ modules/Ubuntu/Components/Extras/Share.qml 2014-02-24 17:19:09 +0000
4@@ -93,9 +93,11 @@
5 width: units.gu(5)
6 height: units.gu(5)
7
8+ // FIXME: replace this by an Icon when UbuntuShape supports
9+ // masking its children
10 image: Image {
11 fillMode: Image.PreserveAspectFit
12- source: "image://gicon/" + accts.provider.iconName
13+ source: "image://theme/%1".arg(accts.provider.iconName)
14 sourceSize.height: logo.height
15 sourceSize.width: logo.width
16 }

Subscribers

People subscribed via source and target branches