Merge lp:~bfiller/ubuntu-keyboard/tweak-haptic into lp:ubuntu-keyboard

Proposed by Bill Filler
Status: Merged
Approved by: Michael Sheldon
Approved revision: 163
Merged at revision: 164
Proposed branch: lp:~bfiller/ubuntu-keyboard/tweak-haptic
Merge into: lp:ubuntu-keyboard
Diff against target: 30 lines (+5/-5)
2 files modified
data/schemas/com.canonical.keyboard.maliit.gschema.xml (+1/-1)
qml/KeyboardContainer.qml (+4/-4)
To merge this branch: bzr merge lp:~bfiller/ubuntu-keyboard/tweak-haptic
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+219260@code.launchpad.net

Commit message

Adjust values of haptic feedback to make less strong and enable by default

Description of the change

Adjust values of haptic feedback to make less strong and enable by default

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/schemas/com.canonical.keyboard.maliit.gschema.xml'
2--- data/schemas/com.canonical.keyboard.maliit.gschema.xml 2014-04-17 11:16:56 +0000
3+++ data/schemas/com.canonical.keyboard.maliit.gschema.xml 2014-05-12 20:29:22 +0000
4@@ -34,7 +34,7 @@
5 <key name="key-press-haptic-feedback" type="b">
6 <summary>Key press haptic feedback</summary>
7 <description>Vibrate on key press.</description>
8- <default>false</default>
9+ <default>true</default>
10 </key>
11 <key name="spell-checking" type="b">
12 <summary>Spell checking</summary>
13
14=== modified file 'qml/KeyboardContainer.qml'
15--- qml/KeyboardContainer.qml 2014-04-08 15:33:05 +0000
16+++ qml/KeyboardContainer.qml 2014-05-12 20:29:22 +0000
17@@ -61,10 +61,10 @@
18 HapticsEffect {
19 id: pressEffect
20 attackIntensity: 0.0
21- attackTime: 125
22- intensity: 0.5
23- duration: 75
24- fadeTime: 125
25+ attackTime: 30
26+ intensity: 0.3
27+ duration: 25
28+ fadeTime: 30
29 fadeIntensity: 0.0
30 }
31

Subscribers

People subscribed via source and target branches