Merge lp:~bfiller/mediaplayer-app/remove-no-display into lp:mediaplayer-app

Proposed by Bill Filler on 2013-09-27
Status: Merged
Merged at revision: 144
Proposed branch: lp:~bfiller/mediaplayer-app/remove-no-display
Merge into: lp:mediaplayer-app
Diff against target: 10 lines (+0/-1)
1 file modified
data/mediaplayer-app.desktop.in (+0/-1)
To merge this branch: bzr merge lp:~bfiller/mediaplayer-app/remove-no-display
Reviewer Review Type Date Requested Status
Didier Roche Approve on 2013-09-30
PS Jenkins bot continuous-integration Needs Fixing on 2013-09-28
Loïc Minier 2013-09-27 Approve on 2013-09-27
Review via email: mp+188092@code.launchpad.net

Commit message

remove NoDisplay=true so that it can be launched via upstart-app-launch

Description of the change

remove NoDisplay=true so that it can be launched via upstart-app-launch

To post a comment you must log in.
Loïc Minier (lool) wrote :

I tested this locally, and it restored Video scope activation.

review: Approve
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Loïc Minier (lool) wrote :

Ah, the autopilot tests for sceneselector are failing of course...
MismatchError: After 10.0 seconds test on SceneSelector.opacity failed: 1 != dbus.Double(0.0, variant_level=1)

Bill, would you mind commenting these out for now?

Loïc Minier (lool) wrote :

That's test_time_display_behavior() and I'm assuming test_show_controls_at_end() is the same issue.

Didier Roche (didrocks) wrote :

Let's push that directly to trunk to get back uri activation on the image. Loïc is going to log a bug for the AP failing

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/mediaplayer-app.desktop.in'
2--- data/mediaplayer-app.desktop.in 2013-09-19 18:37:58 +0000
3+++ data/mediaplayer-app.desktop.in 2013-09-27 16:19:21 +0000
4@@ -6,6 +6,5 @@
5 Exec=mediaplayer-app %u
6 Terminal=false
7 Icon=media-player
8-NoDisplay=true
9 X-Ubuntu-Gettext-Domain=mediaplayer-app
10 X-Ubuntu-Single-Instance=true

Subscribers

People subscribed via source and target branches