dialer-app

Merge lp:~bfiller/dialer-app/app-name-change into lp:dialer-app

  1. app-name-change
  2. Merge into trunk
Proposed by Bill Filler
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 182
Merged at revision: 203
Proposed branch: lp:~bfiller/dialer-app/app-name-change
Merge into: lp:dialer-app
Diff against target: 17 lines (+4/-4)
1 file modified
src/dialer-app.desktop.in.in (+4/-4)
To merge this branch: bzr merge lp:~bfiller/dialer-app/app-name-change
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+227224@code.launchpad.net

Commit message

change name of app per design

Description of the change

change name of app per design

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:182
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/295/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/65
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/65/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2146
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1793
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2362
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3305
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3305/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10018
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1501
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2006
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2006/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/295/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but not related to this MR

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dialer-app.desktop.in.in'
2--- src/dialer-app.desktop.in.in 2014-07-16 20:43:16 +0000
3+++ src/dialer-app.desktop.in.in 2014-07-17 16:38:18 +0000
4@@ -1,9 +1,9 @@
5 [Desktop Entry]
6 Type=Application
7-_Name=Dialer
8-_GenericName=Dialer App
9-_Comment=Dialer application
10-_Keywords=Dialer;Dial;Call;Keypad
11+_Name=Phone
12+_GenericName=Phone App
13+_Comment=Phone application
14+_Keywords=Phone;Dialer;Dial;Call;Keypad
15 Exec=dialer-app %u
16 Terminal=false
17 Icon=dialer-app

Subscribers

People subscribed via source and target branches