Code review comment for lp:~beuno/bzr-upload/ignores

Revision history for this message
Vincent Ladeuil (vila) wrote :

It looks like you re-introduce the README file that has been moved in the __init__.py so that the documentation can be automatically generated.

I suspect that's because you started with an old branch.

The test sounds right, you may want to add one (and some code too :) for directories.

The diff is larger than it should, could it be because you introduced spurious spaces ?

195 + ignored_files = self.get_ignored()
196 + if relpath not in ignored_files:
197 + self.get_ignored()

That self.get_ignored() call seems useless.

review: Needs Fixing

« Back to merge proposal