Merge ~bettyl/plainbox-provider-checkbox:modify-check-fde-tpm into plainbox-provider-checkbox:master

Proposed by Betty Lin
Status: Merged
Approved by: Betty Lin
Approved revision: 40008b556169845ccca77f013d02d10ff1883af2
Merged at revision: 67dd5ab74da927834c30fe71537a2d0bb45e3b4e
Proposed branch: ~bettyl/plainbox-provider-checkbox:modify-check-fde-tpm
Merge into: plainbox-provider-checkbox:master
Diff against target: 23 lines (+7/-5)
1 file modified
units/disk/encryption.pxu (+7/-5)
Reviewer Review Type Date Requested Status
Kristin Chuang (community) Approve
Betty Lin (community) Needs Resubmitting
Pierre Equoy Pending
Sylvain Pineau Pending
Review via email: mp+380466@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

A few typos and a suggestion, please see inline comments :)

review: Needs Fixing
Revision history for this message
Kristin Chuang (kristinchuang) :
Revision history for this message
Betty Lin (bettyl) wrote :

@Kristin, please review again, thanks!

review: Needs Resubmitting
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

Thanks Betty!

+1, looks good to me now.

I've also ran `checkbox-cli run com.canonical.certification::disk/encryption/check-fde-tpm` and confirmed that the modified test can be launched, displayed and run w/o issues.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/disk/encryption.pxu b/units/disk/encryption.pxu
2index b805a37..d4c5df8 100644
3--- a/units/disk/encryption.pxu
4+++ b/units/disk/encryption.pxu
5@@ -37,12 +37,14 @@ _purpose:
6 BIOS), the device won't be able to get the master key and decrypt its data
7 partition.
8 _steps:
9+ NOTE!!!! YOU'LL HAVE TO RE-INSTALL THE IMAGE AFTER THIS TEST
10 1. Install the image and make sure it boots and you can log in.
11- 2. Turn the device off and upgrade/downgrade the BIOS or modify Secure Boot state
12- 3. Make sure the BIOS is set up properly (e.g. TPM enabled, UEFI boot mode)
13- 4. Start the device
14+ 2. Make sure the BIOS is set up properly (e.g. TPM enabled, UEFI boot mode)
15+ 3. Based on your project's situation, choose one of the following methods to clean TPM:
16+ a. Turn the device off and upgrade/downgrade the BIOS or modify Secure Boot state
17+ b. Clean TPM via BIOS menu
18+ c. Install checkbox, execute "checkbox-[project name].checkbox-cli run com.canonical.certification::tpm2.0_3.0.4/tpm2_takeownership"
19+ 4. Start or reboot the device
20 _verification:
21 Mark this test as "Passed" if the device cannot boot anymore.
22- Note: You must flash the BIOS back to the latest version, re-enable Secure Boot
23- and re-install the image afterwards.
24

Subscribers

People subscribed via source and target branches