Checkbox Provider - Base

Merge ~bettyl/plainbox-provider-checkbox:remove-thunderbolt-tests into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bettyl/plainbox-provider-checkbox
  3. remove-thunderbolt-tests
  4. Merge into master
Proposed by Betty Lin
Status: Merged
Approved by: Betty Lin
Approved revision: ec48149dc815478ffc92e07e8d9ccebe1667549b
Merged at revision: 0ecb122c7d5a59f21ff041009712cd784bfa10c4
Proposed branch: ~bettyl/plainbox-provider-checkbox:remove-thunderbolt-tests
Merge into: plainbox-provider-checkbox:master
Diff against target: 123 lines (+0/-34)
2 files modified
units/monitor/test-plan.pxu (+0/-22)
units/thunderbolt/test-plan.pxu (+0/-12)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Betty Lin (community) Needs Resubmitting
Jerry Kao (community) Approve
Sylvain Pineau Pending
Review via email: mp+377114@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jerry Kao (jerry.kao) wrote :

Thanks Betty.

We also need to remove the following tests in monitor and audio.

monitor/1_thunderbolt_.*
audio/1_playback_thunderbolt_.*
thunderbolt/daisy-chain
after-suspend-manual-monitor/1_thunderbolt_.*
after-suspend-manual-audio/1_playback_thunderbolt_.*
after-suspend-manual-thunderbolt/daisy-chain

monitor/2_thunderbolt_.*
audio/2_playback_thunderbolt_.*
after-suspend-manual-monitor/2_thunderbolt_.*
after-suspend-manual-audio/2_playback_thunderbolt_.*
after-suspend-manual-thunderbolt/daisy-chain

review: Needs Fixing
Revision history for this message
Betty Lin (bettyl) wrote :

@Jerry

Updated, thanks!

review: Needs Resubmitting
Revision history for this message
Jerry Kao (jerry.kao) wrote :

+1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

I would prefer if the lines were removed rather than commented out. No problem with the change though.

review: Needs Fixing
Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan, because of thunderbolt 4 is coming soon, so I kept them there

Revision history for this message
Jonathan Cave (jocave) wrote :

I think that commenting them out is just uncertainty that is preferable to not have to manage, I would choose one of 1) delete 2) change to thunderbolt4 now 3) leave as is

Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan, got it, let's remove them now and add thunderbolt 4 related tests when they arrive, thanks.

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/monitor/test-plan.pxu b/units/monitor/test-plan.pxu
2index fd4686a..aa99f3f 100644
3--- a/units/monitor/test-plan.pxu
4+++ b/units/monitor/test-plan.pxu
5@@ -36,9 +36,6 @@ include:
6 monitor/1_dvi_.* certification-status=blocker
7 monitor/1_hdmi_.* certification-status=blocker
8 audio/1_playback_hdmi_.* certification-status=blocker
9- monitor/1_thunderbolt_.* certification-status=blocker
10- audio/1_playback_thunderbolt_.* certification-status=blocker
11- thunderbolt/daisy-chain certification-status=blocker
12 monitor/1_thunderbolt3_.* certification-status=non-blocker
13 audio/1_playback_thunderbolt3_.* certification-status=non-blocker
14 thunderbolt3/daisy-chain certification-status=non-blocker
15@@ -65,9 +62,6 @@ include:
16 after-suspend-manual-monitor/1_dvi_.* certification-status=blocker
17 after-suspend-manual-monitor/1_hdmi_.* certification-status=blocker
18 after-suspend-manual-audio/1_playback_hdmi_.* certification-status=blocker
19- after-suspend-manual-monitor/1_thunderbolt_.* certification-status=blocker
20- after-suspend-manual-audio/1_playback_thunderbolt_.* certification-status=blocker
21- after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
22 after-suspend-manual-monitor/1_thunderbolt3_.* certification-status=non-blocker
23 after-suspend-manual-audio/1_playback_thunderbolt3_.* certification-status=non-blocker
24 after-suspend-manual-thunderbolt3/daisy-chain certification-status=non-blocker
25@@ -116,8 +110,6 @@ include:
26 monitor/2_dvi_.* certification-status=blocker
27 monitor/2_hdmi_.* certification-status=blocker
28 audio/2_playback_hdmi_.* certification-status=blocker
29- monitor/2_thunderbolt_.* certification-status=blocker
30- audio/2_playback_thunderbolt_.* certification-status=blocker
31 monitor/2_thunderbolt3_.* certification-status=non-blocker
32 audio/2_playback_thunderbolt3_.* certification-status=non-blocker
33 monitor/2_vga_.* certification-status=blocker
34@@ -153,9 +145,6 @@ include:
35 after-suspend-manual-monitor/2_dvi_.* certification-status=blocker
36 after-suspend-manual-monitor/2_hdmi_.* certification-status=blocker
37 after-suspend-manual-audio/2_playback_hdmi_.* certification-status=blocker
38- after-suspend-manual-monitor/2_thunderbolt_.* certification-status=blocker
39- after-suspend-manual-audio/2_playback_thunderbolt_.* certification-status=blocker
40- after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
41 after-suspend-manual-monitor/2_thunderbolt3_.* certification-status=non-blocker
42 after-suspend-manual-audio/2_playback_thunderbolt3_.* certification-status=non-blocker
43 after-suspend-manual-thunderbolt3/daisy-chain certification-status=non-blocker
44@@ -191,9 +180,6 @@ include:
45 monitor/1_dvi_.* certification-status=blocker
46 monitor/1_hdmi_.* certification-status=blocker
47 audio/1_playback_hdmi_.* certification-status=blocker
48- monitor/1_thunderbolt_.* certification-status=blocker
49- audio/1_playback_thunderbolt_.* certification-status=blocker
50- thunderbolt/daisy-chain certification-status=blocker
51 monitor/1_vga_.* certification-status=blocker
52 monitor/1_multi-head_.* certification-status=blocker
53 bootstrap_include:
54@@ -216,9 +202,6 @@ include:
55 after-suspend-manual-monitor/1_dvi_.* certification-status=blocker
56 after-suspend-manual-monitor/1_hdmi_.* certification-status=blocker
57 after-suspend-manual-audio/1_playback_hdmi_.* certification-status=blocker
58- after-suspend-manual-monitor/1_thunderbolt_.* certification-status=blocker
59- after-suspend-manual-audio/1_playback_thunderbolt_.* certification-status=blocker
60- after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
61 after-suspend-manual-monitor/1_vga_.* certification-status=blocker
62 after-suspend-manual-monitor/1_multi-head_.* certification-status=blocker
63 bootstrap_include:
64@@ -241,8 +224,6 @@ include:
65 monitor/2_dvi_.* certification-status=blocker
66 monitor/2_hdmi_.* certification-status=blocker
67 audio/2_playback_hdmi_.* certification-status=blocker
68- monitor/2_thunderbolt_.* certification-status=blocker
69- audio/2_playback_thunderbolt_.* certification-status=blocker
70 monitor/2_vga_.* certification-status=blocker
71 monitor/2_multi-head_.* certification-status=blocker
72 bootstrap_include:
73@@ -265,9 +246,6 @@ include:
74 after-suspend-manual-monitor/2_dvi_.* certification-status=blocker
75 after-suspend-manual-monitor/2_hdmi_.* certification-status=blocker
76 after-suspend-manual-audio/2_playback_hdmi_.* certification-status=blocker
77- after-suspend-manual-monitor/2_thunderbolt_.* certification-status=blocker
78- after-suspend-manual-audio/2_playback_thunderbolt_.* certification-status=blocker
79- after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
80 after-suspend-manual-monitor/2_vga_.* certification-status=blocker
81 after-suspend-manual-monitor/2_multi-head_.* certification-status=blocker
82 bootstrap_include:
83diff --git a/units/thunderbolt/test-plan.pxu b/units/thunderbolt/test-plan.pxu
84index 75aa0ac..5015cde 100644
85--- a/units/thunderbolt/test-plan.pxu
86+++ b/units/thunderbolt/test-plan.pxu
87@@ -23,9 +23,6 @@ _name: Thunderbolt tests (Manual)
88 _description:
89 Thunderbolt tests (Manual)
90 include:
91- thunderbolt/insert certification-status=blocker
92- thunderbolt/storage-test certification-status=blocker
93- thunderbolt/remove certification-status=blocker
94 thunderbolt3/insert certification-status=non-blocker
95 thunderbolt3/storage-test certification-status=non-blocker
96 thunderbolt3/remove certification-status=non-blocker
97@@ -43,9 +40,6 @@ unit: test plan
98 _name: Thunderbolt tests (certification blockers only)
99 _description: Thunderbolt tests (certification blockers only)
100 include:
101- thunderbolt/insert certification-status=blocker
102- thunderbolt/storage-test certification-status=blocker
103- thunderbolt/remove certification-status=blocker
104
105 id: after-suspend-thunderbolt-cert-manual
106 unit: test plan
107@@ -53,9 +47,6 @@ _name: Thunderbolt tests (after suspend Manual)
108 _description:
109 Thunderbolt tests (after suspend Manual)
110 include:
111- after-suspend-manual-thunderbolt/insert certification-status=blocker
112- after-suspend-manual-thunderbolt/storage-test certification-status=blocker
113- after-suspend-manual-thunderbolt/remove certification-status=blocker
114 after-suspend-manual-thunderbolt3/insert certification-status=non-blocker
115 after-suspend-manual-thunderbolt3/storage-test certification-status=non-blocker
116 after-suspend-manual-thunderbolt3/remove certification-status=non-blocker
117@@ -65,8 +56,5 @@ unit: test plan
118 _name: Thunderbolt tests (after suspend - certification blockers only)
119 _description: Thunderbolt tests (after suspend - certification blockers only)
120 include:
121- after-suspend-manual-thunderbolt/insert certification-status=blocker
122- after-suspend-manual-thunderbolt/storage-test certification-status=blocker
123- after-suspend-manual-thunderbolt/remove certification-status=blocker
124
125

Subscribers

People subscribed via source and target branches