Merge ~bettyl/plainbox-provider-checkbox:modify-bluetooth-file-transfer into plainbox-provider-checkbox:master

[Betty Lin]

LP: #1837163, #1837164

Confirm the "bluetooth/file-transfer" shows by list-bootstrapped

u@u-Precision-5530:~$ checkbox-cli list-bootstrapped com.canonical.certification::client-cert-18-04 | grep bluetooth
com.canonical.certification::bluetooth/detect-output
com.canonical.certification::bluetooth/audio-a2dp
com.canonical.certification::bluetooth4/HOGP-mouse
com.canonical.certification::bluetooth4/HOGP-keyboard
com.canonical.certification::bluetooth/file-transfer
com.canonical.certification::led/bluetooth
com.canonical.certification::suspend/bluetooth_obex_send_before_suspend
com.canonical.certification::suspend/bluetooth_obex_browse_before_suspend
com.canonical.certification::suspend/bluetooth_obex_get_before_suspend
com.canonical.certification::bluetooth4/beacon_eddystone_url_hci0
com.canonical.certification::suspend/bluetooth_detect_after_suspend
com.canonical.certification::suspend/bluetooth_obex_send_after_suspend
com.canonical.certification::suspend/bluetooth_obex_browse_after_suspend
com.canonical.certification::suspend/bluetooth_obex_get_after_suspend
com.canonical.certification::after-suspend-manual-bluetooth4/beacon_eddystone_url_hci0
com.canonical.certification::suspend/led_after_suspend/bluetooth

[Pierre Equoy (pieq)]

Looks good to me!

Just one minor thing: `_description:` is the old way of writing manual jobs purpose/steps/verification. Instead, it's better to use `_purpose`, `_steps` and `_verification`.

So something like

------------------------------
_description:
 PURPOSE:
     Bla bla bla
 STEPS:
     1. One
     2. Two
     3. Three
 VERIFICATION:
     Does it work?
------------------------------

Can be written:

------------------------------
_purpose:
     Bla bla bla
_steps:
     1. One
     2. Two
     3. Three
_verification:
     Does it work?
------------------------------

(not that in the second case, `_description` is gone)

review: Approve

[Maciej Kisielewski (kissiel)]

Missing indent will break the job. See below.

review: Needs Fixing

[Betty Lin (bettyl)]

@Maciej

I added the indent, thank you!

review: Needs Resubmitting

[Maciej Kisielewski (kissiel)]

Looks good. Thanks for all the patches! +1

review: Approve

diff --git a/units/bluetooth/jobs.pxu b/units/bluetooth/jobs.pxu
index f40a6e0..6160e76 100644
--- a/units/bluetooth/jobs.pxu
+++ b/units/bluetooth/jobs.pxu
@@ -82,11 +82,15 @@ _description:
  PURPOSE:
      This test will check that you can transfer information through a bluetooth connection
  STEPS:
-     1. Make sure that you're able to browse the files in your mobile device
-     2. Copy a file from the computer to the mobile device
-     3. Copy a file from the mobile device to the computer
+     1. Enable bluetooth on a target device (e.g. another laptop) and DUT (device under test)
+     2. Launch bluetooth settings from menu bar
+     3. Select target device from Device options for connection establishing
+     4. Confirm PIN code on both DUT and target device
+     5. Target device is connected
+     7. Click target device in device list
+     8. Click 'Send Files...' and choose a file to send in DUT
  VERIFICATION:
-     Were all files copied correctly?
+     Were file sent to target device ~/Downloads folder correctly?
 
 plugin: user-interact-verify
 category_id: com.canonical.plainbox::bluetooth
diff --git a/units/bluetooth/test-plan.pxu b/units/bluetooth/test-plan.pxu
index 4e48f0d..2b1819b 100644
--- a/units/bluetooth/test-plan.pxu
+++ b/units/bluetooth/test-plan.pxu
@@ -17,7 +17,7 @@ include:
  bluetooth/audio-a2dp                           certification-status=blocker
  bluetooth4/HOGP-mouse                          certification-status=blocker
  bluetooth4/HOGP-keyboard                       certification-status=blocker
-
+ bluetooth/file-transfer                        certification-status=non-blocker
 
 id: bluetooth-cert-automated
 unit: test plan