Checkbox Provider - Base

Merge ~bettyl/plainbox-provider-checkbox:remove-battery-info-hotkey into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bettyl/plainbox-provider-checkbox
  3. remove-battery-info-hotkey
  4. Merge into master
Proposed by Betty Lin
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 26bb407e9dcb3653b0d1210262255ab5f6d2c6f0
Merged at revision: de9378161947cb84c6eb6593907a05d46eaed512
Proposed branch: ~bettyl/plainbox-provider-checkbox:remove-battery-info-hotkey
Merge into: plainbox-provider-checkbox:master
Diff against target: 36 lines (+0/-4)
1 file modified
units/keys/test-plan.pxu (+0/-4)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Maciej Kisielewski Approve
Review via email: mp+370030@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

LGTM, +1.
Great commit message <3

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [01:32:31] starting container
Device project added to bionic-testing
[xenial] [01:32:34] starting container
Device project added to xenial-testing
[bionic] [01:32:44] provisioning container
[xenial] [01:32:44] provisioning container
[bionic] [01:32:51] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/f4F2tHkpNx/
[bionic] [01:32:53] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [01:33:04] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [01:34:16] container-tests-provider-checkbox: PASS
[xenial] [01:34:16] Fixing file permissions in source directory
[xenial] [01:34:16] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [07:40:45] starting container
[xenial] [07:40:45] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[bionic] [07:40:57] provisioning container
[xenial] [07:40:57] provisioning container
[bionic] [07:41:08] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/qNqvCffzqt/
[bionic] [07:41:10] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [07:41:18] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [07:42:30] container-tests-provider-checkbox: PASS
[xenial] [07:42:30] Fixing file permissions in source directory
[xenial] [07:42:31] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [07:44:18] starting container
[xenial] [07:44:18] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[xenial] [07:44:30] provisioning container
[bionic] [07:44:31] provisioning container
[bionic] [07:44:42] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/3qvv25BrfJ/
[bionic] [07:44:44] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [07:44:52] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [07:46:10] container-tests-provider-checkbox: PASS
[xenial] [07:46:10] Fixing file permissions in source directory
[xenial] [07:46:10] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/keys/test-plan.pxu b/units/keys/test-plan.pxu
2index c75a32a..38386ef 100644
3--- a/units/keys/test-plan.pxu
4+++ b/units/keys/test-plan.pxu
5@@ -16,7 +16,6 @@ _description:
6 include:
7 keys/lock-screen certification-status=blocker
8 keys/super certification-status=blocker
9- keys/battery-info certification-status=blocker
10 keys/brightness certification-status=blocker
11 keys/media-control certification-status=blocker
12 keys/mute certification-status=blocker
13@@ -42,7 +41,6 @@ _description:
14 include:
15 after-suspend-manual-keys/lock-screen certification-status=blocker
16 after-suspend-manual-keys/super certification-status=blocker
17- after-suspend-manual-keys/battery-info certification-status=blocker
18 after-suspend-manual-keys/brightness certification-status=blocker
19 after-suspend-manual-keys/media-control certification-status=blocker
20 after-suspend-manual-keys/mute certification-status=blocker
21@@ -61,7 +59,6 @@ _description:
22 include:
23 keys/lock-screen certification-status=blocker
24 keys/super certification-status=blocker
25- keys/battery-info certification-status=blocker
26 keys/brightness certification-status=blocker
27 keys/media-control certification-status=blocker
28 keys/mute certification-status=blocker
29@@ -79,7 +76,6 @@ _description:
30 include:
31 after-suspend-manual-keys/lock-screen certification-status=blocker
32 after-suspend-manual-keys/super certification-status=blocker
33- after-suspend-manual-keys/battery-info certification-status=blocker
34 after-suspend-manual-keys/brightness certification-status=blocker
35 after-suspend-manual-keys/media-control certification-status=blocker
36 after-suspend-manual-keys/mute certification-status=blocker

Subscribers

People subscribed via source and target branches