Merge lp:~bertrand-rousseau/gtg/bug-988235 into lp:~gtg/gtg/old-trunk

[Bertrand Rousseau]

This branch fixes bug 988235 (task & tag refresh in the browser). This is coupled to another commit in liblarch: https://github.com/liblarch/liblarch/pull/3 (get_nodes() function is required to make this work)

To test it you will need to checkout my liblarch branch on github: https://github.com/broussea/liblarch

[lp:~bertrand-rousseau/gtg/bug-988235]

1180. By Bertrand Rousseau on 2012-05-05

Fix a bug: forget to notify change when delete an attribute. Add a bit of documentation too

[Izidor Matušov (izidor)]

You replace all occurrencies of get_n_nodes() with len(get_nodes()) I am against this step because get_n_nodes() allows speed optimizations on the side of liblarch.

I suggest to remove the line 'assert my_task is not None, "Unknown task id: %s" % task_id' - if my_task is None, python would discover that and raise an exception. The result would be the same, just a different name of exception. There shouldn't be any case to catch None at this place. In other words, it is a redundant line which doesn't add anything, just add a redundant check.

review: Needs Fixing (code)

[lp:~bertrand-rousseau/gtg/bug-988235]

1181. By Bertrand Rousseau on 2012-06-03

Fix following Izidor's review

1182. By Bertrand Rousseau on 2012-06-03

Merge trunk

[Bertrand Rousseau (bertrand-rousseau)]

Ok, I've made the fix you asked for.

[Izidor Matušov (izidor)]

Thanks for a good work!

review: Approve

=== modified file 'GTG/core/tag.py'
--- GTG/core/tag.py	2012-05-20 19:01:02 +0000
+++ GTG/core/tag.py	2012-06-03 21:03:18 +0000
@@ -84,17 +84,23 @@
         @param att_value: The value of the attribute. Will be converted to a
             string.
         """
+        modified = False
         if att_name == "name":
             raise Set_Name_Attribute_Error(
                 "The name of tag cannot be set manually")
         elif att_name == "parent":
             self.add_parent(att_value)
+            modified = True
         else:
             # Attributes should all be strings.
             val = unicode(str(att_value), "UTF-8")
             self._attributes[att_name] = val
             if self._save:
                 self._save()
+            modified = True
+        if modified:
+            self.modified()
+            self.notify_related_tasks()
 
     def get_attribute(self, att_name):
         """Get the attribute C{att_name}.
@@ -125,6 +131,8 @@
             del self._attributes[att_name]
         if self._save:
             self._save()
+        self.modified()
+        self.notify_related_tasks()
 
     def get_all_attributes(self, butname=False, withparent=False):
         """Return a list of all attribute names.
@@ -151,6 +159,10 @@
         return self.__get_count()
 
     def __get_count(self, tasktree=None):
+        """Returns the number of all related tasks"""
+        # this method purposefully doesn't rely on get_related_tasks()
+        # which does a similar job, in order to benefit from liblarch
+        # optimizations
         if not tasktree:
             tasktree = self.req.get_tasks_tree()
         sp_id = self.get_attribute("special")
@@ -168,6 +180,31 @@
                                 withfilters=[tname], include_transparent=False)
         return toreturn
 
+    def get_related_tasks(self, tasktree=None):
+        """Returns all related tasks node ids"""
+        if not tasktree:
+            tasktree = self.req.get_tasks_tree()
+        sp_id = self.get_attribute("special")
+        if sp_id == "all":
+            toreturn = tasktree.get_nodes(\
+                    withfilters=['active'], include_transparent=False)
+        elif sp_id == "notag":
+            toreturn = tasktree.get_nodes(\
+                            withfilters=['notag'], include_transparent=False)
+        elif sp_id == "sep" :
+            toreturn = []
+        else:
+            tname = self.get_name()
+            toreturn = tasktree.get_nodes(\
+                                withfilters=[tname], include_transparent=False)
+        return toreturn
+
+    def notify_related_tasks(self):
+        """Notify changes to all related tasks"""
+        for task_id in self.get_related_tasks():
+            my_task = self.req.get_task(task_id)
+            my_task.modified()
+
     #is it useful to keep the tag in the tagstore.
     #if no attributes and no tasks, it is not useful.
     def is_removable(self):