Merge lp:~benste/kdeedu/bugfix-lp-698056 into lp:~kubuntu-packagers/kubuntu-packaging/kdeedu

Proposed by benste
Status: Merged
Merged at revision: 120
Proposed branch: lp:~benste/kdeedu/bugfix-lp-698056
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/kdeedu
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~benste/kdeedu/bugfix-lp-698056
Reviewer Review Type Date Requested Status
Harald Sitter Approve
Rohan Garg Pending
Review via email: mp+45408@code.launchpad.net

Description of the change

new attempt, fixing the simple dependency issue, and using the kubuntu changelog style :-)

To post a comment you must log in.
Revision history for this message
Harald Sitter (apachelogger) wrote :

As supsected in the bug report the change was not all that right, in fact Parley's scripting thingy uses kross which can be either krosspython or krossruby, the package now recommends both. Additionally the default scripts use pykde rather than pyqt, fixed that too.

Anyhow, there is cool things to be learned from this:
Since Parley still works without the python magic, depends is not the appropriate relation, but recommends is. The reason for this is that someone might want to install without the python packages and could still use Parley quite normal (well, except for the error), however for the average user recommends will just like depends install the packages and thus provide a good user experience :)
Recommends is a weaker relationship than depends, and for optional scripting capabilities usually recommends is what ought to be used (depends on the particular case at hand of course).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-01-05 15:38:20 +0000
3+++ debian/changelog 2011-01-06 16:18:11 +0000
4@@ -1,3 +1,9 @@
5+kdeedu (4:4.5.95-0ubuntu1~ppa2) UNRELEASED; urgency=low
6+
7+ * debian/control: add python-qt4 dependency for parley (LP:#698056)
8+
9+ -- Benedict Stein <Benedict.Stein+ubuntu@gmail.com> Thu, 06 Jan 2011 15:53:30 +0100
10+
11 kdeedu (4:4.5.95-0ubuntu1~ppa1) natty; urgency=low
12
13 * New upstream release
14
15=== modified file 'debian/control'
16--- debian/control 2010-12-23 13:47:24 +0000
17+++ debian/control 2011-01-06 16:18:11 +0000
18@@ -522,7 +522,7 @@
19
20 Package: parley
21 Architecture: any
22-Depends: ${shlibs:Depends}, ${misc:Depends}, libwww-perl,
23+Depends: ${shlibs:Depends}, ${misc:Depends}, libwww-perl, python-qt4,
24 parley-data (>= ${source:Version}), kdeedu-kvtml-data (= ${source:Version})
25 Replaces: parley-data (<< 4:4.1.86)
26 Breaks: parley-data (<< 4:4.1.86)

Subscribers

People subscribed via source and target branches

to all changes: