Merge lp:~benoit.pierre/sloecode/860915-permission-denied-trace into lp:sloecode

Proposed by Benoit Pierre
Status: Merged
Merge reported by: Thomi Richards
Merged at revision: not available
Proposed branch: lp:~benoit.pierre/sloecode/860915-permission-denied-trace
Merge into: lp:sloecode
Diff against target: 11 lines (+1/-1)
1 file modified
sloecode/codehosting/server.py (+1/-1)
To merge this branch: bzr merge lp:~benoit.pierre/sloecode/860915-permission-denied-trace
Reviewer Review Type Date Requested Status
Thomi Richards (community) Approve
Review via email: mp+77237@code.launchpad.net

Description of the change

Before:

> bzr info sc:~foo/
Sloecode Bazaar Smart Server
bzr: ERROR: Server sent an unexpected error: ('error', 'TypeError', 'not enough arguments for format string')

After:

> bzr info sc:~foo/
Sloecode Bazaar Smart Server
bzr: ERROR: Permission denied: "You (bpierre) do not have access to user foo's branches."

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Looks good to me. Merging into trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sloecode/codehosting/server.py'
2--- sloecode/codehosting/server.py 2011-05-05 19:24:31 +0000
3+++ sloecode/codehosting/server.py 2011-09-27 21:16:36 +0000
4@@ -123,7 +123,7 @@
5 if username != self.username and not self.is_admin:
6 raise PermissionDenied(
7 "You (%s) do not have access to user %s's branches." %
8- self.username, username)
9+ (self.username, username))
10 transport = self.user_transport.clone(username)
11 return transport
12

Subscribers

People subscribed via source and target branches