Merge lp:~benoit.pierre/bzrtools/shell_improvement_kbd_interrupt into lp:bzrtools

Proposed by Benoit Pierre
Status: Merged
Merged at revision: not available
Proposed branch: lp:~benoit.pierre/bzrtools/shell_improvement_kbd_interrupt
Merge into: lp:bzrtools
Diff against target: None lines
To merge this branch: bzr merge lp:~benoit.pierre/bzrtools/shell_improvement_kbd_interrupt
Reviewer Review Type Date Requested Status
Aaron Bentley Approve
Review via email: mp+12187@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

Looks good. At first, I thought the order should be reversed so that a KeyboardInterrupt caused prompt.write_history to be executed, but the history is remembered, so that's not needed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell.py'
2--- shell.py 2008-02-13 04:58:32 +0000
3+++ shell.py 2009-09-21 19:31:17 +0000
4@@ -223,10 +223,14 @@
5 def run_shell():
6 try:
7 prompt = PromptCmd()
8- try:
9- prompt.cmdloop()
10- finally:
11- prompt.write_history()
12+ while True:
13+ try:
14+ try:
15+ prompt.cmdloop()
16+ except KeyboardInterrupt:
17+ print
18+ finally:
19+ prompt.write_history()
20 except StopIteration:
21 pass
22

Subscribers

People subscribed via source and target branches