Merge lp:~benny/ubuntu-community-accomplishments/ubuntu-irc-member into lp:~ubuntu-community-accomplishments-reviewers/ubuntu-community-accomplishments/0.1

Proposed by Benjamin Donald-Wilson
Status: Rejected
Rejected by: Jono Bacon
Proposed branch: lp:~benny/ubuntu-community-accomplishments/ubuntu-irc-member
Merge into: lp:~ubuntu-community-accomplishments-reviewers/ubuntu-community-accomplishments/0.1
Diff against target: 69 lines (+60/-0)
2 files modified
accomplishments/ubuntu-community/en/ubuntu-irc-member.accomplishment (+19/-0)
scripts/ubuntu-community/ubuntu-irc-member.py (+41/-0)
To merge this branch: bzr merge lp:~benny/ubuntu-community-accomplishments/ubuntu-irc-member
Reviewer Review Type Date Requested Status
Jono Bacon Disapprove
Review via email: mp+105571@code.launchpad.net

Description of the change

I've created a accomplishment for being a Ubuntu IRC Member.

To post a comment you must log in.
Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks for your contribution, Ben!

Given that we already have an accomplishment for Ubuntu Member, I think it would be better if you could expand the documentation there to include details of how you can become an Ubuntu Member by getting reviewed by the IRC Council. If you could modify those docs and submit a MP, that would be awesome! Thanks!

Revision history for this message
Jono Bacon (jonobacon) :
review: Disapprove

Unmerged revisions

113. By Benjamin Donald-Wilson

Created Ubuntu IRC Member accomplishment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'accomplishments/ubuntu-community/en/ubuntu-irc-member.accomplishment'
2--- accomplishments/ubuntu-community/en/ubuntu-irc-member.accomplishment 1970-01-01 00:00:00 +0000
3+++ accomplishments/ubuntu-community/en/ubuntu-irc-member.accomplishment 2012-05-12 23:52:19 +0000
4@@ -0,0 +1,19 @@
5+[accomplishment]
6+title=Ubuntu IRC Member
7+description=You gained Ubuntu Membership via IRC Contributions
8+application=ubuntu-community
9+category=General
10+needs-signing=true
11+icon=default.png
12+needs-information=launchpad-email
13+depends=ubuntu-community/ubuntu-member
14+summary = Ubuntu membership generally recognizes significant and sustained contributions to Ubuntu. An active IRC contributor is held to the same standards, but the main focus of activity is in the Ubuntu IRC channels.
15+steps: Create a <a href="https://wiki.ubuntu.com/username">wiki page</a>.
16+ Create a <a href="https://launchpad.net">Launchpad</a> page.
17+ Sign the Ubuntu code of conduct. This has traditionally been one of the more difficult steps.
18+ Add your name to <a href="https://wiki.ubuntu.com/IRC/IrcCouncil/MeetingAgenda">the Ubuntu IRC Council meeting agenda</a> requesting a review of your application. Be sure to include a link to your wiki and launchpad pages.
19+ We would strongly advise you read through <a href="https://wiki.ubuntu.com/IRC/Membership">this</a> wiki page before applying for membership.
20+ The IRC Council meets monthly and membership applications are processed at this time. For information on when the IRC Council meet please check <a href="https://wiki.ubuntu.com/IRC/IrcCouncil/MeetingAgenda">this</a> wiki page.
21+links: https://wiki.ubuntu.com/IRC/IrcCouncil/MeetingAgenda
22+ https://wiki.ubuntu.com/IRC/Membership
23+help = #ubuntu-irc on Freenode
24
25=== added file 'scripts/ubuntu-community/ubuntu-irc-member.py'
26--- scripts/ubuntu-community/ubuntu-irc-member.py 1970-01-01 00:00:00 +0000
27+++ scripts/ubuntu-community/ubuntu-irc-member.py 2012-05-12 23:52:19 +0000
28@@ -0,0 +1,41 @@
29+#!/usr/bin/python
30+import traceback, sys
31+
32+from accomplishments.daemon import dbusapi
33+from launchpadlib.launchpad import Launchpad
34+
35+try:
36+ api = dbusapi.Accomplishments()
37+ f = api.get_extra_information("ubuntu-community", "launchpad-email")
38+ if bool(f[0]["launchpad-email"]) == False:
39+ sys.exit(4)
40+ else:
41+ email = f[0]["launchpad-email"]
42+ lp = Launchpad.login_anonymously(
43+ 'ubuntu-community accomplishments', 'production')
44+ me = lp.people.getByEmail(email=email)
45+ if me == None:
46+ sys.exit(1)
47+ else:
48+ user = me.name
49+ teams = [team.name for team in lp.people['ubuntu-irc-members'].sub_teams]
50+ if teams == []:
51+ teams.append(lp.people['ubuntu-irc-members'].name)
52+ try:
53+ memberships = [
54+ membership for membership in
55+ lp.people[user].memberships_details
56+ if membership.team_link.rsplit('~', 1)[-1] in
57+ ['ubuntu-irc-members'] + teams]
58+ except KeyError:
59+ memberships = []
60+ if memberships:
61+ sys.exit(0)
62+ else:
63+ sys.exit(1)
64+
65+except SystemExit, e:
66+ sys.exit(e.code)
67+except:
68+ traceback.print_exc()
69+ sys.exit(2)

Subscribers

People subscribed via source and target branches