Hi Benji,
Your changes as suggested by Gavin look good. We discussed the following on IRC:
1) Capitalize and punctuate
import _pythonpath # not lint, actually needed
2) alphabetize:
20 from lp.testing.matchers import ( 21 StartsWith, 22 Contains, 23 )
3) Use a tuple instead of a list: 54 args = ['xsltproc', stylesheet, wadl_filename]
Thanks for the branch. I enjoyed seeing how matchers work and are extended.
« Back to merge proposal
Hi Benji,
Your changes as suggested by Gavin look good. We discussed the following on IRC:
1) Capitalize and punctuate
import _pythonpath # not lint, actually needed
2) alphabetize:
20 from lp.testing.matchers import (
21 StartsWith,
22 Contains,
23 )
3) Use a tuple instead of a list:
54 args = ['xsltproc', stylesheet, wadl_filename]
Thanks for the branch. I enjoyed seeing how matchers work and are extended.