Merge lp:~benji/launchpad/bug-972456 into lp:launchpad
Proposed by
Benji York
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15056 |
Proposed branch: | lp:~benji/launchpad/bug-972456 |
Merge into: | lp:launchpad |
Diff against target: |
19 lines (+8/-1) 1 file modified
bzrplugins/lpserve/test_lpserve.py (+8/-1) |
To merge this branch: | bzr merge lp:~benji/launchpad/bug-972456 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+100645@code.launchpad.net |
Commit message
Ignore warnings when starting a bzr subprocess.
Description of the change
Bug 972456 is about several test failures that occur when bzr warns
about a badly configured locale.
The problem is that _start_subprocess in
bzrplugins/
(on stderr) will be the "Listening on socket:" line. When bzr issues
warnings they come before that line so the subsequent assertEqual fails.
To fix this I just keep reading lines of output until we see the
"Listening" line and then proceed.
Lint: the "make lint" report is clean.
QA: this is a test fix only, so no QA step.
To post a comment you must log in.