Merge lp:~benji/launchpad/bug-963463 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15053 |
Proposed branch: | lp:~benji/launchpad/bug-963463 |
Merge into: | lp:launchpad |
Diff against target: |
210 lines (+48/-6) 1 file modified
lib/lp/registry/tests/test_distributionmirror_prober.py (+48/-6) |
To merge this branch: | bzr merge lp:~benji/launchpad/bug-963463 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+100514@code.launchpad.net |
Commit message
Fix tests that use twisted and leave DelayedCalls, uncalled in the reactor.
Description of the change
Bug 963463 is about tests failing intermittently when run in groups (in
parallel, but that doesn't matter).
The problem is that there are tests that use twisted and leave
DelayedCalls, uncalled in the reactor. Tests using testtools later
detect the dirty reactor and generates an error.
This branch fixes several (all?) instances of those tests by giving them
a tearDown that clears out the reactor.
Lint: "make lint" reported several "E301 expected 1 blank line, found 0"
in ./lib/lp/
fixed.
QA: since this is a testing bug, there is no QA to do.
Hey Benji this looks great. On IRC I twisted (ha!) into agreeing to add a helper function so those common bits aren't repeated.
Thanks.