Merge lp:~benji/launchpad/bug-777766 into lp:launchpad
Proposed by
Benji York
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Benji York | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12993 | ||||
Proposed branch: | lp:~benji/launchpad/bug-777766 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
44 lines (+13/-2) 2 files modified
lib/lp/app/widgets/popup.py (+9/-1) lib/lp/app/widgets/tests/test_popup.py (+4/-1) |
||||
To merge this branch: | bzr merge lp:~benji/launchpad/bug-777766 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email:
|
Commit message
[r=jcsackett][bug=777766] fix invalid ID generation
Description of the change
Bug 777766 describes a JS error that occurs because an element ID
contains invalid characters. This branch (url-safe) base 64 encodes the
name before using it in the ID.
The make lint report is clean.
The tests for the widget can be run thusly:
bin/test -c -t test_popup -m lp.app.
To QA this branch create a project with a plus in it's URL, create a bug
in that project and then navigate to the bug page. If no JS errors are
reported and the Subscribers portlet is populated, it worked.
To post a comment you must log in.
Looks good, thanks!