Merge lp:~benji/launchpad/bug-735196 into lp:launchpad

[Benji York]

[r=jcsackett][bug=735196] clip overly-long strings of non-whitespace characters in announcements

Bug 735196 is about the announcements portlet sometimes having long
strings of non-whitespace characters (like section headers) that break
out of the page element. Since those strings of characters are
essentially information-free and announcements that use them are not
formatted to fit in the portlet's preview anyway (there is a link to the
full version), we (Huw and I) decided that simply clipping text that
overflows the bounds of the portlet is the best compromise.

Lint: there was so much lint in the one CSS file that I changed that I'm
not even going to think about fixing it in this branch.

[j.c.sackett (jcsackett)]

Looks good.

review: Approve

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2011-06-17 17:33:14 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2011-06-27 13:34:59 +0000
@@ -1456,6 +1456,10 @@
     }
 .announcements li {
     margin-bottom: 0.5em;
+    /* Some announcements have long strings of characters as section headers
+     * and such.  Since they don't have whitespace they can't wrap, so they
+     * would break out of their container if we didn't clip them here. */
+    overflow: hidden;
     }
 .announcements li strong,
 .announcements li a {