Code review comment for lp:~benji/launchpad/bug-649252

Revision history for this message
Benji York (benji) wrote :

> "Neither does Verbose Team Person" doesn't make sense anymore--you should
> change it to something like "Verbose Team Person gets a concise email, even
> though they belong to a team that gets verbose email."

Thanks. Fixed.

> I also don't understand why you added the two blank lines starting on line 44
> of the diff.

The way Python string formatting is used to fill in the templates causes
trailing newlines. I just fixed this by adding a .strip() to the email
body after the template is filled in. I was then able to remove all the
trailing <BLANKLINE>s in the test.

« Back to merge proposal