Merge lp:~benji/launchpad/bug-590014 into lp:launchpad
Proposed by
Benji York
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Benji York | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13624 | ||||
Proposed branch: | lp:~benji/launchpad/bug-590014 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
172 lines (+47/-37) 3 files modified
lib/lp/translations/browser/configure.zcml (+0/-14) lib/lp/translations/browser/person.py (+45/-21) lib/lp/translations/templates/person-translations.pt (+2/-2) |
||||
To merge this branch: | bzr merge lp:~benji/launchpad/bug-590014 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+70614@code.launchpad.net |
Commit message
[r=bac][bug=590014] remove some duplicate queries
Description of the change
This branch reduces the number of queries needed to render the
translations page for a person by refactoring the code such that already
run queries are retained by cachedproperty decorators.
Tests for the view can be run with this command:
bin/test -c -m lp.translations
Lint: the lint report is clean
QA: Compare translations.
translations.
similar (not that some lists are randomized so variances there are to be
expected).
To post a comment you must log in.
I like these changes Benji. A good idea to not instantiate the view multiple times.