Merge lp:~benji/launchpad/bug-436247 into lp:launchpad
Proposed by
Benji York
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Benji York | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13351 | ||||
Proposed branch: | lp:~benji/launchpad/bug-436247 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
171 lines (+44/-56) 4 files modified
lib/canonical/launchpad/icing/style-3-0.css (+1/-1) lib/lp/bugs/javascript/subscribers_list.js (+2/-2) lib/lp/bugs/templates/bug-portlet-actions.pt (+28/-42) lib/lp/bugs/templates/bug-portlet-subscription.pt (+13/-11) |
||||
To merge this branch: | bzr merge lp:~benji/launchpad/bug-436247 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+66336@code.launchpad.net |
Commit message
[r=stevenk][bug=436247] change unordered lists to use <ul>
Description of the change
Bug 436247 is about the lists of "things" in portlets should be marked
up with <ul> and <li> instead of <div>. This branch fixes that.
There are before and after screen shots attached (hopefully, if not,
I'll add a comment later pointing to them).
Lint: there is no lint, except for
./lib/canonical
because fixing it would be a project in itself. Maybe next time.
Tests: there aren't any affected tests.
QA: check to see if pages with portlets (bug pages especially) look
right and lists therein are built with unordered lists.
To post a comment you must log in.
Hmm, no file attachments for MPs.
Before: http:// i.imgur. com/r9dUD. png i.imgur. com/kiXbC. png
After: http://