Merge lp:~benji/launchpad/bug-423151 into lp:launchpad

Proposed by Benji York
Status: Merged
Approved by: Benji York
Approved revision: no longer in the source branch.
Merged at revision: 13320
Proposed branch: lp:~benji/launchpad/bug-423151
Merge into: lp:launchpad
Diff against target: 12 lines (+5/-0)
1 file modified
lib/canonical/launchpad/icing/style-3-0.css (+5/-0)
To merge this branch: bzr merge lp:~benji/launchpad/bug-423151
Reviewer Review Type Date Requested Status
Benji York (community) Approve
Review via email: mp+66109@code.launchpad.net

Commit message

[r=benji][bug=423151] make messages display above all other page elements

Description of the change

Bug 423151 describes a situation where an error message box is overlapped by another page element. The problem was that z-index of the page element's z-index is 1 and the default z-index of the message box is 0. This branch changes the message box's z-index to a large number so that it will always display on top of the other page elements.

Tests: there are no automated tests to check for this.
Lint: there is so much lint in that file that I'm not even thinking about fixing it in this branch.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Self review of one-line change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
2--- lib/canonical/launchpad/icing/style-3-0.css 2011-06-28 14:57:35 +0000
3+++ lib/canonical/launchpad/icing/style-3-0.css 2011-06-28 15:19:34 +0000
4@@ -2245,3 +2245,8 @@
5 div.translation-help-links div {
6 clear: both;
7 }
8+/* Message boxes (especially error boxes) should be visible above other
9+ * elments. */
10+.yui3-activator-message-box {
11+ z-index: 9999;
12+ }