Merge lp:~benji/launchpad/bug-191199 into lp:launchpad

Proposed by Benji York
Status: Merged
Approved by: Benji York
Approved revision: no longer in the source branch.
Merged at revision: 13240
Proposed branch: lp:~benji/launchpad/bug-191199
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~benji/launchpad/bug-191199
Reviewer Review Type Date Requested Status
j.c.sackett (community) Approve
Review via email: mp+64058@code.launchpad.net

Commit message

[r=jcsackett][bug=191199] tolerate ASCII control characters in bugzilla imports

Description of the change

Bug 191199 describes a problem importing Bugzilla bugs that contain ASCII control characters. This branch fixes the problem by stripping low-ASCII control characters (other than the whitespace characters \n\r\t) after encoding to UTF-8. This is safe because non-ASCII characters in UTF-8 are represented with the high bit set and therefore won't be confused as ASCII control characters.

After fixing some minor pre-existing lint, the lint report is clear.

To post a comment you must log in.
Revision history for this message
j.c.sackett (jcsackett) wrote :

This looks good to land.

review: Approve

Preview Diff

Empty