Merge lp:~benji/launchpad/bug-1011793 into lp:launchpad

Proposed by Benji York
Status: Merged
Approved by: Benji York
Approved revision: 15397
Merged at revision: 15401
Proposed branch: lp:~benji/launchpad/bug-1011793
Merge into: lp:launchpad
Diff against target: 7 lines (+2/-0)
1 file modified
logs/README.txt (+2/-0)
To merge this branch: bzr merge lp:~benji/launchpad/bug-1011793
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+109871@code.launchpad.net

Commit message

Create the "logs" directory in the repo instead of depending on it being created as a side effect of starting Launchpad or running particular tests.

Description of the change

Bug 1011793 is about a test failing when run in parallel because the
"logs" directory doesn't exist. It turns out that the "logs" directory
gets created as a side effect of starting Launchpad or running
particular tests.

Instead, this branch simply creates the directory so development and
test environments won't have to depend on side effects. The code to
create the log directory -- especially for production -- has been left
alone because creating the directory as needed makes the most sense in
that situation.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)
lp:~benji/launchpad/bug-1011793 updated
15398. By Benji York

add README so the (otherwise empty) logs directory isn't removed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'logs'
2=== added file 'logs/README.txt'
3--- logs/README.txt 1970-01-01 00:00:00 +0000
4+++ logs/README.txt 2012-06-12 16:57:20 +0000
5@@ -0,0 +1,2 @@
6+This -- otherwise empty -- directory is here so tests will have it available to
7+fill with logs.