Merge lp:~benji/launchpad/bug-1011793 into lp:launchpad
Proposed by
Benji York
on 2012-06-12
| Status: | Merged |
|---|---|
| Approved by: | Benji York on 2012-06-12 |
| Approved revision: | 15397 |
| Merged at revision: | 15401 |
| Proposed branch: | lp:~benji/launchpad/bug-1011793 |
| Merge into: | lp:launchpad |
| Diff against target: |
7 lines (+2/-0) 1 file modified
logs/README.txt (+2/-0) |
| To merge this branch: | bzr merge lp:~benji/launchpad/bug-1011793 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | 2012-06-12 | Approve on 2012-06-12 |
|
Review via email:
|
|||
Commit Message
Create the "logs" directory in the repo instead of depending on it being created as a side effect of starting Launchpad or running particular tests.
Description of the Change
Bug 1011793 is about a test failing when run in parallel because the
"logs" directory doesn't exist. It turns out that the "logs" directory
gets created as a side effect of starting Launchpad or running
particular tests.
Instead, this branch simply creates the directory so development and
test environments won't have to depend on side effects. The code to
create the log directory -- especially for production -- has been left
alone because creating the directory as needed makes the most sense in
that situation.
To post a comment you must log in.
review:
Approve
(code)
lp:~benji/launchpad/bug-1011793
updated
on 2012-06-12
- 15398. By Benji York on 2012-06-12
-
add README so the (otherwise empty) logs directory isn't removed
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
