Merge lp:~benji/launchpad/bug-1011793-2 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Benji York |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15418 |
Proposed branch: | lp:~benji/launchpad/bug-1011793-2 |
Merge into: | lp:launchpad |
Diff against target: |
23 lines (+3/-1) 2 files modified
.bzrignore (+1/-1) logs/README.txt (+2/-0) |
To merge this branch: | bzr merge lp:~benji/launchpad/bug-1011793-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | Approve | ||
Review via email: mp+110338@code.launchpad.net |
Commit message
Create the "logs" directory in the repo instead of depending on it being created as a side effect of starting Launchpad or running particular tests.
Description of the change
Bug 1011793 is about a test failing when run in parallel because the
"logs" directory doesn't exist. It turns out that the "logs" directory
gets created as a side effect of starting Launchpad or running
particular tests.
Instead, this branch simply creates the directory so development and
test environments won't have to depend on side effects. The code to
create the log directory -- especially for production -- has been left
alone because creating the directory as needed makes the most sense in
that situation.
Unfortunately I had a brain/bzr interface malfunction and removed the
logs directory after comitting an earlier fix. For that reason I will
be self-reviewing this MP.
Self review for reasons stated above.